test: refactor test-vm-new-script-new-context

* block scope test cases
* clean up global leaks in individual test cases
* enable global variable leak checking
* remove console.error() statements
PR-URL: #14536
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: Trott

test/parallel/test-vm-new-script-new-context.js

@@ -1,69 +1,86 @@
 'use strict';
-constcommon=require('../common');
+require('../common');
+
 constassert=require('assert');
+
 constScript=require('vm').Script;
 
-common.globalCheck=false;
+{
+constscript=newScript('\'passed\';');
+constresult1=script.runInNewContext();
+constresult2=script.runInNewContext();
+assert.strictEqual('passed',result1);
+assert.strictEqual('passed',result2);
+}
 
-console.error('run a string');
-letscript=newScript('\'passed\';');
-console.error('script created');
-constresult1=script.runInNewContext();
-constresult2=script.runInNewContext();
-assert.strictEqual('passed',result1);
-assert.strictEqual('passed',result2);
+{
+constscript=newScript('throw new Error(\'test\');');
+assert.throws(function(){
+script.runInNewContext();
+},/^Error:test$/);
+}
 
-console.error('thrown error');
-script=newScript('throw new Error(\'test\');');
-assert.throws(function(){
-script.runInNewContext();
-},/^Error:test$/);
+{
+constscript=newScript('foo.bar = 5;');
+assert.throws(function(){
+script.runInNewContext();
+},/^ReferenceError:fooisnotdefined$/);
+}
 
-
-console.error('undefined reference');
-script=newScript('foo.bar = 5;');
-assert.throws(function(){
+{
+global.hello=5;
+constscript=newScript('hello = 2');
 script.runInNewContext();
-},/^ReferenceError:fooisnotdefined$/);
+assert.strictEqual(5,global.hello);
 
+// cleanup
+deleteglobal.hello;
+}
 
-global.hello=5;
-script=newScript('hello = 2');
-script.runInNewContext();
-assert.strictEqual(5,global.hello);
+{
+global.code='foo = 1;'+
+'bar = 2;'+
+'if (baz !== 3) throw new Error(\'test fail\');';
+global.foo=2;
+global.obj={foo: 0,baz: 3};
+constscript=newScript(global.code);
+/* eslint-disable no-unused-vars */
+constbaz=script.runInNewContext(global.obj);
+/* eslint-enable no-unused-vars */
+assert.strictEqual(1,global.obj.foo);
+assert.strictEqual(2,global.obj.bar);
+assert.strictEqual(2,global.foo);
 
+//cleanup
+deleteglobal.code;
+deleteglobal.foo;
+deleteglobal.obj;
+}
 
-console.error('pass values in and out');
-global.code='foo = 1;'+
-'bar = 2;'+
-'if (baz !== 3) throw new Error(\'test fail\');';
-global.foo=2;
-global.obj={foo: 0,baz: 3};
-script=newScript(global.code);
-/* eslint-disable no-unused-vars */
-constbaz=script.runInNewContext(global.obj);
-/* eslint-enable no-unused-vars */
-assert.strictEqual(1,global.obj.foo);
-assert.strictEqual(2,global.obj.bar);
-assert.strictEqual(2,global.foo);
+{
+constscript=newScript('f()');
+functionchangeFoo(){global.foo=100;}
+script.runInNewContext({f: changeFoo});
+assert.strictEqual(global.foo,100);
 
-console.error('call a function by reference');
-script=newScript('f()');
-functionchangeFoo(){global.foo=100;}
-script.runInNewContext({f: changeFoo});
-assert.strictEqual(global.foo,100);
+// cleanup
+deleteglobal.foo;
+}
 
-console.error('modify an object by reference');
-script=newScript('f.a = 2');
-constf={a: 1};
-script.runInNewContext({f: f});
-assert.strictEqual(f.a,2);
+{
+constscript=newScript('f.a = 2');
+constf={a: 1};
+script.runInNewContext({f: f});
+assert.strictEqual(f.a,2);
 
-assert.throws(function(){
-script.runInNewContext();
-},/^ReferenceError:fisnotdefined$/);
+assert.throws(function(){
+script.runInNewContext();
+},/^ReferenceError:fisnotdefined$/);
+}
 
-console.error('invalid this');
-assert.throws(function(){
-script.runInNewContext.call('\'hello\';');
-},/^TypeError:this\.runInContextisnotafunction$/);
+{
+constscript=newScript('');
+assert.throws(function(){
+script.runInNewContext.call('\'hello\';');
+},/^TypeError:this\.runInContextisnotafunction$/);
+}