test_runner: fix global after not failing the tests

PR-URL: #48913
Backport-PR-URL: #49225Fixes: #48867
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Author: rluvaton

lib/internal/test_runner/test.js

@@ -688,6 +688,14 @@ class Test extends AsyncResource {
 this.parent.processReadySubtestRange(false);
 this.parent.processPendingSubtests();
 }elseif(!this.reported){
+if(!this.passed&&failed===0&&this.error){
+this.reporter.fail(0,kFilename,this.subtests.length+1,kFilename,{
+__proto__: null,
+duration_ms: this.#duration(),
+error: this.error,
+},undefined);
+}
+
 this.reported=true;
 this.reporter.plan(this.nesting,kFilename,this.root.harness.counters.topLevel);
 

test/common/assertSnapshot.js

@@ -20,6 +20,10 @@ function replaceWindowsPaths(str) {
 returncommon.isWindows ? str.replaceAll(path.win32.sep,path.posix.sep) : str;
 }
 
+functionreplaceFullPaths(str){
+returnstr.replaceAll(process.cwd(),'');
+}
+
 functiontransform(...args){
 return(str)=>args.reduce((acc,fn)=>fn(acc),str);
 }
@@ -79,6 +83,7 @@ async function spawnAndAssert(filename, transform = (x) => x, { tty = false, ...
 module.exports={
  assertSnapshot,
  getSnapshotPath,
+ replaceFullPaths,
  replaceStackTrace,
  replaceWindowsLineEndings,
  replaceWindowsPaths,

test/fixtures/test-runner/output/global_after_should_fail_the_test.js

@@ -0,0 +1,10 @@
+'use strict';
+const{ it, after }=require('node:test');
+
+after(()=>{
+thrownewError('this should fail the test')
+});
+
+it('this is a test',()=>{
+console.log('this is a test')
+});

test/fixtures/test-runner/output/global_after_should_fail_the_test.snapshot

@@ -0,0 +1,34 @@
+this is a test
+TAP version 13
+# Subtest: this is a test
+ok 1 - this is a test
+ ---
+ duration_ms: *
+ ...
+not ok 2 - /test/fixtures/test-runner/output/global_after_should_fail_the_test.js
+ ---
+ duration_ms: *
+ failureType: 'hookFailed'
+ error: 'this should fail the test'
+ code: 'ERR_TEST_FAILURE'
+ stack: |-
+ *
+ *
+ *
+ *
+ *
+ *
+ *
+ *
+ *
+ *
+ ...
+1..1
+# tests 1
+# suites 0
+# pass 1
+# fail 0
+# cancelled 0
+# skipped 0
+# todo 0
+# duration_ms *

test/fixtures/test-runner/output/hooks-with-no-global-test.js

@@ -9,42 +9,36 @@ before(() => testArr.push('global before'));
 after(()=>{
 testArr.push('global after');
 
-try{
-assert.deepStrictEqual(testArr,[
-'global before',
-'describe before',
+assert.deepStrictEqual(testArr,[
+'global before',
+'describe before',
 
-'describe beforeEach',
-'describe it 1',
-'describe afterEach',
+'describe beforeEach',
+'describe it 1',
+'describe afterEach',
 
-'describe beforeEach',
-'describe test 2',
-'describe afterEach',
+'describe beforeEach',
+'describe test 2',
+'describe afterEach',
 
-'describe nested before',
+'describe nested before',
 
-'describe beforeEach',
-'describe nested beforeEach',
-'describe nested it 1',
-'describe afterEach',
-'describe nested afterEach',
+'describe beforeEach',
+'describe nested beforeEach',
+'describe nested it 1',
+'describe afterEach',
+'describe nested afterEach',
 
-'describe beforeEach',
-'describe nested beforeEach',
-'describe nested test 2',
-'describe afterEach',
-'describe nested afterEach',
+'describe beforeEach',
+'describe nested beforeEach',
+'describe nested test 2',
+'describe afterEach',
+'describe nested afterEach',
 
-'describe nested after',
-'describe after',
-'global after',
-]);
-}catch(e){
-// TODO(rluvaton): remove the try catch after #48867 is fixed
-console.error(e);
-process.exit(1);
-}
+'describe nested after',
+'describe after',
+'global after',
+]);
 });
 
 describe('describe hooks with no global tests',()=>{

test/parallel/test-runner-output.mjs

@@ -24,10 +24,27 @@ function replaceSpecDuration(str) {
 .replaceAll(/duration_ms[0-9.]+/g,'duration_ms *')
 .replace(stackTraceBasePath,'$3');
 }
-constdefaultTransform=snapshot
-.transform(snapshot.replaceWindowsLineEndings,snapshot.replaceStackTrace,replaceTestDuration);
-constspecTransform=snapshot
-.transform(replaceSpecDuration,snapshot.replaceWindowsLineEndings,snapshot.replaceStackTrace);
+
+functionremoveWindowsPathEscaping(str){
+returncommon.isWindows ? str.replaceAll(/\\\\/g,'\\') : str;
+}
+
+constdefaultTransform=snapshot.transform(
+snapshot.replaceWindowsLineEndings,
+snapshot.replaceStackTrace,
+replaceTestDuration,
+);
+constspecTransform=snapshot.transform(
+replaceSpecDuration,
+snapshot.replaceWindowsLineEndings,
+snapshot.replaceStackTrace,
+);
+constwithFileNameTransform=snapshot.transform(
+defaultTransform,
+removeWindowsPathEscaping,
+snapshot.replaceFullPaths,
+snapshot.replaceWindowsPaths,
+);
 
 
 consttests=[
@@ -41,6 +58,7 @@ const tests = [
 {name: 'test-runner/output/hooks-with-no-global-test.js'},
 {name: 'test-runner/output/before-and-after-each-too-many-listeners.js'},
 {name: 'test-runner/output/before-and-after-each-with-timeout-too-many-listeners.js'},
+{name: 'test-runner/output/global_after_should_fail_the_test.js',transform: withFileNameTransform},
 {name: 'test-runner/output/no_refs.js'},
 {name: 'test-runner/output/no_tests.js'},
 {name: 'test-runner/output/only_tests.js'},