test: increase wiggle room for memory in test-worker-resource-limits

Trott · targos · commit 4c5eff91ef95 · 2021-05-01T12:25:28.000+02:00
PR-URL: #37901 Fixes: #37844 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/test/parallel/test-worker-resource-limits.js b/test/parallel/test-worker-resource-limits.js
@@ -35,9 +35,10 @@ if (!process.env.HAS_STARTED_WORKER) {
 assert.deepStrictEqual(resourceLimits, testResourceLimits);
 const array = [];
 while (true) {
- // Leave 10 % wiggle room here.
+ // Leave 10% wiggle room here, and 20% on debug builds.
+ const wiggleRoom = common.buildType === 'Release' ? 1.1 : 1.2;
 const usedMB = v8.getHeapStatistics().used_heap_size / 1024 / 1024;
- assert(usedMB < resourceLimits.maxOldGenerationSizeMb * 1.1);
+ assert(usedMB < resourceLimits.maxOldGenerationSizeMb * wiggleRoom);
 
 let seenSpaces = 0;
 for (const { space_name, space_size } of v8.getHeapSpaceStatistics()) {

-Original file line number
+Diff line change
 assert.deepStrictEqual(resourceLimits,testResourceLimits);
 constarray=[];
 while(true){
 -// Leave 10 % wiggle room here.
 +// Leave 10% wiggle room here, and 20% on debug builds.
 +constwiggleRoom=common.buildType==='Release' ? 1.1 : 1.2;
 constusedMB=v8.getHeapStatistics().used_heap_size/1024/1024;
 -assert(usedMB<resourceLimits.maxOldGenerationSizeMb*1.1);
 +assert(usedMB<resourceLimits.maxOldGenerationSizeMb*wiggleRoom);
 letseenSpaces=0;
 for(const{ space_name, space_size }ofv8.getHeapSpaceStatistics()){