benchmark: refactor deepequal-object

Trott · MylesBorins · commit 4d714421e9ab · 2018-06-06T10:31:28.000+02:00
This is a minor refactor of benchmark/assert/deepequal-object.js to reduce exceptions that need to be made for lint compliance. PR-URL: #21030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/benchmark/assert/deepequal-object.js b/benchmark/assert/deepequal-object.js
@@ -29,13 +29,15 @@ function main({ size, n, method }) {
 // TODO: Fix this "hack". `n` should not be manipulated.
 n = n / size;
 
+ if (!method)
+ method = 'deepEqual';
+
 const source = Array.apply(null, Array(size));
 const actual = createObj(source);
 const expected = createObj(source);
 const expectedWrong = createObj(source, '4');
 
- // eslint-disable-next-line no-restricted-properties
- const fn = method !== '' ? assert[method] : assert.deepEqual;
+ const fn = assert[method];
 const value2 = method.includes('not') ? expectedWrong : expected;
 
 bench.start();

-Original file line number
+Diff line change
 // TODO: Fix this "hack". `n` should not be manipulated.
 n=n/size;
 +if(!method)
 +method='deepEqual';
++
 constsource=Array.apply(null,Array(size));
 constactual=createObj(source);
 constexpected=createObj(source);
 constexpectedWrong=createObj(source,'4');
 -// eslint-disable-next-line no-restricted-properties
 -constfn=method!=='' ? assert[method] : assert.deepEqual;
 +constfn=assert[method];
 constvalue2=method.includes('not') ? expectedWrong : expected;
 bench.start();