perf_hooks: move deprecated accessors to EOF

Additional accessors on PerformanceEntry objects
have been deprecated in favor of the detail property
for a number of years now. This removes them.
PR-URL: #58531
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Author: jasnell

doc/api/deprecations.md

@@ -3143,18 +3143,21 @@ an explicit [`"exports"` or `"main"` entry][] with the exact file extension.
 
 <!-- YAML
 changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/58531
+ description: End-of-Life.
  - version: v16.0.0
  pr-url: https://github.com/nodejs/node/pull/37136
  description: Runtime deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The `'gc'`, `'http2'`, and `'http'` {PerformanceEntry} object types have
+The `'gc'`, `'http2'`, and `'http'` {PerformanceEntry} object types used to have
 additional properties assigned to them that provide additional information.
 These properties are now available within the standard `detail` property
-of the `PerformanceEntry` object. The existing accessors have been
-deprecated and should no longer be used.
+of the `PerformanceEntry` object. The deprecated accessors have been
+removed.
 
 ### DEP0153: `dns.lookup` and `dnsPromises.lookup` options type coercion
 

lib/internal/perf/observe.js

@@ -14,7 +14,6 @@ const {
  MathMin,
  ObjectDefineProperties,
  ObjectFreeze,
- ObjectKeys,
  SafeMap,
  SafeSet,
  Symbol,
@@ -57,7 +56,6 @@ const {
 
 const{
 customInspectSymbol: kInspect,
- deprecate,
  lazyDOMException,
  kEmptyObject,
  kEnumerableProperty,
@@ -74,11 +72,6 @@ const { now } = require('internal/perf/utils');
 constkBuffer=Symbol('kBuffer');
 constkDispatch=Symbol('kDispatch');
 constkMaybeBuffer=Symbol('kMaybeBuffer');
-constkDeprecatedFields=Symbol('kDeprecatedFields');
-
-constkDeprecationMessage=
-'Custom PerformanceEntry accessors are deprecated. '+
-'Please use the detail property.';
 
 constkTypeSingle=0;
 constkTypeMultiple=1;
@@ -536,32 +529,6 @@ function observerCallback(name, type, startTime, duration, details) {
 duration,
 details);
 
-if(details!==undefined){
-// GC, HTTP2, and HTTP PerformanceEntry used additional
-// properties directly off the entry. Those have been
-// moved into the details property. The existing accessors
-// are still included but are deprecated.
-entry[kDeprecatedFields]=newSafeMap();
-
-constdetailKeys=ObjectKeys(details);
-constprops={};
-for(letn=0;n<detailKeys.length;n++){
-constkey=detailKeys[n];
-entry[kDeprecatedFields].set(key,details[key]);
-props[key]={
-configurable: true,
-enumerable: true,
-get: deprecate(()=>{
-returnentry[kDeprecatedFields].get(key);
-},kDeprecationMessage,'DEP0152'),
-set: deprecate((value)=>{
-entry[kDeprecatedFields].set(key,value);
-},kDeprecationMessage,'DEP0152'),
-};
-}
-ObjectDefineProperties(entry,props);
-}
-
 enqueue(entry);
 }
 

test/parallel/test-http2-perf_hooks.js

@@ -16,14 +16,6 @@ const obs = new PerformanceObserver(common.mustCallAtLeast((items) => {
 assert.strictEqual(typeofentry.duration,'number');
 switch(entry.name){
 case'Http2Session':
-assert.strictEqual(typeofentry.pingRTT,'number');
-assert.strictEqual(typeofentry.streamAverageDuration,'number');
-assert.strictEqual(typeofentry.streamCount,'number');
-assert.strictEqual(typeofentry.framesReceived,'number');
-assert.strictEqual(typeofentry.framesSent,'number');
-assert.strictEqual(typeofentry.bytesWritten,'number');
-assert.strictEqual(typeofentry.bytesRead,'number');
-assert.strictEqual(typeofentry.maxConcurrentStreams,'number');
 assert.strictEqual(typeofentry.detail.pingRTT,'number');
 assert.strictEqual(typeofentry.detail.streamAverageDuration,'number');
 assert.strictEqual(typeofentry.detail.streamCount,'number');
@@ -32,7 +24,7 @@ const obs = new PerformanceObserver(common.mustCallAtLeast((items) => {
 assert.strictEqual(typeofentry.detail.bytesWritten,'number');
 assert.strictEqual(typeofentry.detail.bytesRead,'number');
 assert.strictEqual(typeofentry.detail.maxConcurrentStreams,'number');
-switch(entry.type){
+switch(entry.detail.type){
 case'server':
 assert.strictEqual(entry.detail.streamCount,1);
 assert(entry.detail.framesReceived>=3);
@@ -46,11 +38,6 @@ const obs = new PerformanceObserver(common.mustCallAtLeast((items) => {
 }
 break;
 case'Http2Stream':
-assert.strictEqual(typeofentry.timeToFirstByte,'number');
-assert.strictEqual(typeofentry.timeToFirstByteSent,'number');
-assert.strictEqual(typeofentry.timeToFirstHeader,'number');
-assert.strictEqual(typeofentry.bytesWritten,'number');
-assert.strictEqual(typeofentry.bytesRead,'number');
 assert.strictEqual(typeofentry.detail.timeToFirstByte,'number');
 assert.strictEqual(typeofentry.detail.timeToFirstByteSent,'number');
 assert.strictEqual(typeofentry.detail.timeToFirstHeader,'number');

test/parallel/test-performance-gc.js

@@ -30,9 +30,7 @@ const kinds = [
 assert(entry);
 assert.strictEqual(entry.name,'gc');
 assert.strictEqual(entry.entryType,'gc');
-assert(kinds.includes(entry.kind));
 assert(kinds.includes(entry.detail.kind));
-assert.strictEqual(entry.flags,NODE_PERFORMANCE_GC_FLAGS_FORCED);
 assert.strictEqual(entry.detail.flags,NODE_PERFORMANCE_GC_FLAGS_FORCED);
 assert.strictEqual(typeofentry.startTime,'number');
 assert(entry.startTime<1e4,'startTime should be relative to performance.timeOrigin.');