lib: replace createDeferredPromise util with Promise.withResolvers

PR-URL: #54836
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Author: anonrig

lib/child_process.js

@@ -37,6 +37,7 @@ const {
  ObjectAssign,
  ObjectDefineProperty,
  ObjectPrototypeHasOwnProperty,
+ PromiseWithResolvers,
  RegExpPrototypeExec,
  SafeSet,
  StringPrototypeIncludes,
@@ -47,7 +48,6 @@ const {
 
 const{
  convertToValidSignal,
- createDeferredPromise,
  getSystemErrorName,
  kEmptyObject,
  promisify,
@@ -237,7 +237,7 @@ function exec(command, options, callback) {
 
 constcustomPromiseExecFunction=(orig)=>{
 return(...args)=>{
-const{ promise, resolve, reject }=createDeferredPromise();
+const{ promise, resolve, reject }=PromiseWithResolvers();
 
 promise.child=orig(...args,(err,stdout,stderr)=>{
 if(err!==null){

lib/internal/abort_controller.js

@@ -10,6 +10,7 @@ const {
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
  PromiseResolve,
+ PromiseWithResolvers,
  SafeFinalizationRegistry,
  SafeSet,
  SafeWeakRef,
@@ -28,7 +29,6 @@ const {
  kWeakHandler,
 }=require('internal/event_target');
 const{
- createDeferredPromise,
  customInspectSymbol,
  kEmptyObject,
  kEnumerableProperty,
@@ -486,7 +486,7 @@ async function aborted(signal, resource) {
 validateObject(resource,'resource',kValidateObjectAllowObjects);
 if(signal.aborted)
 returnPromiseResolve();
-constabortPromise=createDeferredPromise();
+constabortPromise=PromiseWithResolvers();
 constopts={__proto__: null,[kWeakHandler]: resource,once: true,[kResistStopPropagation]: true};
 signal.addEventListener('abort',abortPromise.resolve,opts);
 returnabortPromise.promise;

lib/internal/blob.js

@@ -9,6 +9,7 @@ const {
  ObjectSetPrototypeOf,
  PromisePrototypeThen,
  PromiseReject,
+ PromiseWithResolvers,
  RegExpPrototypeExec,
  RegExpPrototypeSymbolReplace,
  StringPrototypeSplit,
@@ -47,7 +48,6 @@ const {
 }=require('internal/util/types');
 
 const{
- createDeferredPromise,
 customInspectSymbol: kInspect,
  kEmptyObject,
  kEnumerableProperty,
@@ -325,7 +325,7 @@ class Blob {
 this.pendingPulls=[];
 },
 pull(c){
-const{ promise, resolve, reject }=createDeferredPromise();
+const{ promise, resolve, reject }=PromiseWithResolvers();
 this.pendingPulls.push({ resolve, reject });
 constreadNext=()=>{
 reader.pull((status,buffer)=>{
@@ -478,7 +478,7 @@ function createBlobFromFilePath(path, options) {
 }
 
 functionarrayBuffer(blob){
-const{ promise, resolve, reject }=createDeferredPromise();
+const{ promise, resolve, reject }=PromiseWithResolvers();
 constreader=blob[kHandle].getReader();
 constbuffers=[];
 constreadNext=()=>{

lib/internal/fs/watchers.js

@@ -4,6 +4,7 @@ const {
  FunctionPrototypeCall,
  ObjectDefineProperty,
  ObjectSetPrototypeOf,
+ PromiseWithResolvers,
  Symbol,
 }=primordials;
 
@@ -15,7 +16,6 @@ const {
 },
 }=require('internal/errors');
 const{
- createDeferredPromise,
  kEmptyObject,
 }=require('internal/util');
 
@@ -325,7 +325,7 @@ async function* watch(filename, options = kEmptyObject) {
 thrownewAbortError(undefined,{cause: signal?.reason});
 
 consthandle=newFSEvent();
-let{ promise, resolve, reject }=createDeferredPromise();
+let{ promise, resolve, reject }=PromiseWithResolvers();
 constoncancel=()=>{
 handle.close();
 reject(newAbortError(undefined,{cause: signal?.reason}));
@@ -368,7 +368,7 @@ async function* watch(filename, options = kEmptyObject) {
 
 while(!signal?.aborted){
 yieldawaitpromise;
-({ promise, resolve, reject }=createDeferredPromise());
+({ promise, resolve, reject }=PromiseWithResolvers());
 }
 thrownewAbortError(undefined,{cause: signal?.reason});
 }finally{

lib/internal/streams/duplexify.js

@@ -2,6 +2,7 @@
 
 const{
  FunctionPrototypeCall,
+ PromiseWithResolvers,
 }=primordials;
 
 const{
@@ -27,7 +28,6 @@ const { destroyer } = require('internal/streams/destroy');
 constDuplex=require('internal/streams/duplex');
 constReadable=require('internal/streams/readable');
 constWritable=require('internal/streams/writable');
-const{ createDeferredPromise }=require('internal/util');
 constfrom=require('internal/streams/from');
 
 const{
@@ -209,7 +209,7 @@ module.exports = function duplexify(body, name) {
 };
 
 functionfromAsyncGen(fn){
-let{ promise, resolve }=createDeferredPromise();
+let{ promise, resolve }=PromiseWithResolvers();
 constac=newAbortController();
 constsignal=ac.signal;
 constvalue=fn(asyncfunction*(){
@@ -221,7 +221,7 @@ function fromAsyncGen(fn) {
 if(done)return;
 if(signal.aborted)
 thrownewAbortError(undefined,{cause: signal.reason});
-({ promise, resolve }=createDeferredPromise());
+({ promise, resolve }=PromiseWithResolvers());
 yieldchunk;
 }
 }(),{ signal });

lib/internal/test_runner/harness.js

@@ -4,6 +4,7 @@ const {
  ArrayPrototypePush,
  FunctionPrototypeBind,
  PromiseResolve,
+ PromiseWithResolvers,
  SafeMap,
  SafePromiseAllReturnVoid,
 }=primordials;
@@ -26,7 +27,6 @@ const {
  shouldColorizeTestFiles,
 }=require('internal/test_runner/utils');
 const{ queueMicrotask }=require('internal/process/task_queues');
-const{ createDeferredPromise }=require('internal/util');
 const{bigint: hrtime}=process.hrtime;
 constresolvedPromise=PromiseResolve();
 consttestResources=newSafeMap();
@@ -35,7 +35,7 @@ let globalRoot;
 testResources.set(reporterScope.asyncId(),reporterScope);
 
 functioncreateTestTree(rootTestOptions,globalOptions){
-constbuildPhaseDeferred=createDeferredPromise();
+constbuildPhaseDeferred=PromiseWithResolvers();
 constisFilteringByName=globalOptions.testNamePatterns||
 globalOptions.testSkipPatterns;
 constisFilteringByOnly=(globalOptions.isolation==='process'||process.env.NODE_TEST_CONTEXT) ?

lib/internal/test_runner/runner.js

@@ -18,6 +18,7 @@ const {
  ObjectAssign,
  PromisePrototypeThen,
  PromiseResolve,
+ PromiseWithResolvers,
  SafeMap,
  SafePromiseAll,
  SafePromiseAllReturnVoid,
@@ -63,7 +64,6 @@ const { getInspectPort, isUsingInspector, isInspectorMessage } = require('intern
 const{ isRegExp }=require('internal/util/types');
 const{ pathToFileURL }=require('internal/url');
 const{
- createDeferredPromise,
  kEmptyObject,
 }=require('internal/util');
 const{ kEmitMessage }=require('internal/test_runner/tests_stream');
@@ -744,7 +744,7 @@ function run(options = kEmptyObject) {
 };
 }else{
 runFiles=async()=>{
-const{ promise,resolve: finishBootstrap}=createDeferredPromise();
+const{ promise,resolve: finishBootstrap}=PromiseWithResolvers();
 
 awaitroot.runInAsyncScope(async()=>{
 constparentURL=pathToFileURL(cwd+sep).href;

lib/internal/test_runner/test.js

@@ -18,6 +18,7 @@ const {
  Promise,
  PromisePrototypeThen,
  PromiseResolve,
+ PromiseWithResolvers,
  ReflectApply,
  RegExpPrototypeExec,
  SafeMap,
@@ -53,7 +54,6 @@ const {
  reporterScope,
 }=require('internal/test_runner/utils');
 const{
- createDeferredPromise,
  kEmptyObject,
 once: runOnce,
 }=require('internal/util');
@@ -137,7 +137,7 @@ function lazyAssertObject(harness) {
 }
 
 functionstopTest(timeout,signal){
-constdeferred=createDeferredPromise();
+constdeferred=PromiseWithResolvers();
 constabortListener=addAbortListener(signal,deferred.resolve);
 lettimer;
 letdisposeFunction;
@@ -822,7 +822,7 @@ class Test extends AsyncResource {
 // pending for later execution.
 this.reporter.enqueue(this.nesting,this.loc,this.name);
 if(this.root.harness.buildPromise||!this.parent.hasConcurrency()){
-constdeferred=createDeferredPromise();
+constdeferred=PromiseWithResolvers();
 
 deferred.test=this;
 this.parent.addPendingSubtest(deferred);

lib/internal/test_runner/utils.js

@@ -14,6 +14,7 @@ const {
  NumberParseInt,
  NumberPrototypeToFixed,
  ObjectGetOwnPropertyDescriptor,
+ PromiseWithResolvers,
  RegExp,
  RegExpPrototypeExec,
  SafeMap,
@@ -29,7 +30,6 @@ const { AsyncResource } = require('async_hooks');
 const{ relative, sep }=require('path');
 const{ createWriteStream }=require('fs');
 const{ pathToFileURL }=require('internal/url');
-const{ createDeferredPromise }=require('internal/util');
 const{ getOptionValue }=require('internal/options');
 const{ green, yellow, red, white, shouldColorize }=require('internal/util/colors');
 
@@ -62,7 +62,7 @@ const kDefaultPattern = `**/{${ArrayPrototypeJoin(kPatterns, ',')}}.{${ArrayProt
 
 functioncreateDeferredCallback(){
 letcalledCount=0;
-const{ promise, resolve, reject }=createDeferredPromise();
+const{ promise, resolve, reject }=PromiseWithResolvers();
 constcb=(err)=>{
 calledCount++;
 

lib/internal/util.js

@@ -543,17 +543,6 @@ function sleep(msec) {
 _sleep(msec);
 }
 
-functioncreateDeferredPromise(){
-letresolve;
-letreject;
-constpromise=newPromise((res,rej)=>{
-resolve=res;
-reject=rej;
-});
-
-return{ promise, resolve, reject };
-}
-
 // https://heycam.github.io/webidl/#define-the-operations
 functiondefineOperation(target,name,method){
 ObjectDefineProperty(target,name,{
@@ -872,7 +861,6 @@ module.exports = {
  cachedResult,
  convertToValidSignal,
  createClassWrapper,
- createDeferredPromise,
  decorateErrorStack,
  defineOperation,
  defineLazyProperties,