test: fix flaky repl-timeout-throw

santigimeno · rvagg · commit 4eca50a2a0e2 · 2018-08-16T11:38:53.000+10:00
Don't disconnect the child until all exceptions are thrown. Fixes: #18659 PR-URL: #18692 Fixes: #18659 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/sequential/test-repl-timeout-throw.js b/test/sequential/test-repl-timeout-throw.js
@@ -1,5 +1,5 @@
 'use strict';
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 
 const spawn = require('child_process').spawn;
@@ -13,6 +13,8 @@ child.stdout.setEncoding('utf8');
 child.stdout.on('data', function(c) {
 process.stdout.write(c);
 stdout += c;
+ if (stdout.includes('> THROW 2'))
+ child.stdin.end();
 });
 
 child.stdin.write = function(original) {
@@ -46,8 +48,6 @@ child.stdout.once('data', function() {
 ' });\n' +
 ' });\n' +
 '});"";\n');
-
- setTimeout(child.stdin.end.bind(child.stdin), common.platformTimeout(200));
 }
 });
 

-Original file line number
+Diff line change
@@ @@ -1,5 +1,5 @@ @@
 'use strict';
 -constcommon=require('../common');
 +require('../common');
 constassert=require('assert');
 constspawn=require('child_process').spawn;
 child.stdout.on('data',function(c){
 process.stdout.write(c);
 stdout+=c;
 +if(stdout.includes('> THROW 2'))
 +child.stdin.end();
 });
 child.stdin.write=function(original){
 ' });\n'+
 ' });\n'+
 '});"";\n');
+-
 -setTimeout(child.stdin.end.bind(child.stdin),common.platformTimeout(200));
+}
 });