lib: use validateString

hotpineapple · RafaelGSS · commit 4ee467905dd1 · 2025-08-12T09:19:59.000-03:00
refactor validation code using validate function PR-URL: #59296 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
diff --git a/lib/_http_client.js b/lib/_http_client.js
@@ -80,6 +80,7 @@ const {
 const {
 validateInteger,
 validateBoolean,
+ validateString,
 } = require('internal/validators');
 const { getTimerDuration } = require('internal/timers');
 const {
@@ -270,12 +271,11 @@ function ClientRequest(input, options, cb) {
 delete optsWithoutSignal.signal;
 }
 let method = options.method;
- const methodIsString = (typeof method === 'string');
- if (method !== null && method !== undefined && !methodIsString) {
- throw new ERR_INVALID_ARG_TYPE('options.method', 'string', method);
+ if (method != null) {
+ validateString(method, 'options.method');
 }
 
- if (methodIsString && method) {
+ if (method) {
 if (!checkIsHttpToken(method)) {
 throw new ERR_INVALID_HTTP_TOKEN('Method', method);
 }

-Original file line number
+Diff line change
 const{
  validateInteger,
  validateBoolean,
 + validateString,
 }=require('internal/validators');
 const{ getTimerDuration }=require('internal/timers');
 const{
 deleteoptsWithoutSignal.signal;
+}
 letmethod=options.method;
 -constmethodIsString=(typeofmethod==='string');
 -if(method!==null&&method!==undefined&&!methodIsString){
 -thrownewERR_INVALID_ARG_TYPE('options.method','string',method);
 +if(method!=null){
 +validateString(method,'options.method');
+}
 -if(methodIsString&&method){
 +if(method){
 if(!checkIsHttpToken(method)){
 thrownewERR_INVALID_HTTP_TOKEN('Method',method);
+}