events: optimize EventTarget.addEventListener

PR-URL: #55312Fixes: #55311
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: ronag

benchmark/events/eventtarget-add-remove-abort.js

@@ -0,0 +1,25 @@
+'use strict';
+constcommon=require('../common.js');
+
+constbench=common.createBenchmark(main,{
+n: [1e5],
+nListener: [1,5,10],
+});
+
+functionmain({ n, nListener }){
+consttarget=newEventTarget();
+constlisteners=[];
+for(letk=0;k<nListener;k+=1)
+listeners.push(()=>{});
+
+bench.start();
+for(leti=0;i<n;i+=1){
+for(letk=listeners.length;--k>=0;){
+target.addEventListener('abort',listeners[k]);
+}
+for(letk=listeners.length;--k>=0;){
+target.removeEventListener('abort',listeners[k]);
+}
+}
+bench.end(n);
+}

benchmark/events/eventtarget-add-remove.js

@@ -2,8 +2,8 @@
 constcommon=require('../common.js');
 
 constbench=common.createBenchmark(main,{
-n: [1e6],
-nListener: [5,10],
+n: [1e5],
+nListener: [1,5,10],
 });
 
 functionmain({ n, nListener }){

lib/internal/event_target.js

@@ -597,19 +597,40 @@ class EventTarget {
 if(arguments.length<2)
 thrownewERR_MISSING_ARGS('type','listener');
 
-// We validateOptions before the validateListener check because the spec
-// requires us to hit getters.
-const{
- once,
- capture,
- passive,
- signal,
- isNodeStyleListener,
- weak,
- resistStopPropagation,
-}=validateEventListenerOptions(options);
-
-validateAbortSignal(signal,'options.signal');
+letonce=false;
+letcapture=false;
+letpassive=false;
+letisNodeStyleListener=false;
+letweak=false;
+letresistStopPropagation=false;
+
+if(options!==kEmptyObject){
+// We validateOptions before the validateListener check because the spec
+// requires us to hit getters.
+options=validateEventListenerOptions(options);
+
+once=options.once;
+capture=options.capture;
+passive=options.passive;
+isNodeStyleListener=options.isNodeStyleListener;
+weak=options.weak;
+resistStopPropagation=options.resistStopPropagation;
+
+constsignal=options.signal;
+
+validateAbortSignal(signal,'options.signal');
+
+if(signal){
+if(signal.aborted){
+return;
+}
+// TODO(benjamingr) make this weak somehow? ideally the signal would
+// not prevent the event target from GC.
+signal.addEventListener('abort',()=>{
+this.removeEventListener(type,listener,options);
+},{__proto__: null,once: true,[kWeakHandler]: this,[kResistStopPropagation]: true});
+}
+}
 
 if(!validateEventListener(listener)){
 // The DOM silently allows passing undefined as a second argument
@@ -623,18 +644,8 @@ class EventTarget {
 process.emitWarning(w);
 return;
 }
-type=webidl.converters.DOMString(type);
 
-if(signal){
-if(signal.aborted){
-return;
-}
-// TODO(benjamingr) make this weak somehow? ideally the signal would
-// not prevent the event target from GC.
-signal.addEventListener('abort',()=>{
-this.removeEventListener(type,listener,options);
-},{__proto__: null,once: true,[kWeakHandler]: this,[kResistStopPropagation]: true});
-}
+type=webidl.converters.DOMString(type);
 
 letroot=this[kEvents].get(type);