lib: throw from localStorage getter on missing storage path

PR-URL: #60351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

Author: Renegade334

lib/internal/webstorage.js

@@ -1,9 +1,9 @@
 'use strict';
 const{
  ObjectDefineProperties,
- Proxy,
 }=primordials;
 const{ getOptionValue }=require('internal/options');
+const{ lazyDOMException }=require('internal/util');
 const{ kConstructorKey, Storage }=internalBinding('webstorage');
 const{ getValidatedPath }=require('internal/fs/utils');
 constkInMemoryPath=':memory:';
@@ -21,34 +21,17 @@ ObjectDefineProperties(module.exports, {
 enumerable: true,
 get(){
 if(lazyLocalStorage===undefined){
+// For consistency with the web specification, throw from the accessor
+// if the local storage path is not provided.
 constlocation=getOptionValue('--localstorage-file');
-
 if(location===''){
-letwarningEmitted=false;
-consthandler={
-__proto__: null,
-get(target,prop){
-if(!warningEmitted){
-process.emitWarning('`--localstorage-file` was provided without a valid path');
-warningEmitted=true;
-}
-
-returnundefined;
-},
-set(target,prop,value){
-if(!warningEmitted){
-process.emitWarning('`--localstorage-file` was provided without a valid path');
-warningEmitted=true;
-}
-
-returnfalse;
-},
-};
-
-lazyLocalStorage=newProxy({},handler);
-}else{
-lazyLocalStorage=newStorage(kConstructorKey,getValidatedPath(location));
+throwlazyDOMException(
+'Cannot initialize local storage without a `--localstorage-file` path',
+'SecurityError',
+);
 }
+
+lazyLocalStorage=newStorage(kConstructorKey,getValidatedPath(location));
 }
 
 returnlazyLocalStorage;

test/common/index.js

@@ -59,6 +59,14 @@ const hasSQLite = Boolean(process.versions.sqlite);
 
 consthasQuic=hasCrypto&&!!process.features.quic;
 
+consthasLocalStorage=(()=>{
+try{
+returnhasSQLite&&globalThis.localStorage!==undefined;
+}catch{
+returnfalse;
+}
+})();
+
 /**
  * Parse test metadata from the specified file.
  * @param {string} filename - The name of the file to parse.
@@ -350,7 +358,6 @@ const knownGlobals = new Set([
 'CompressionStream',
 'DecompressionStream',
 'Storage',
-'localStorage',
 'sessionStorage',
 ].forEach((i)=>{
 if(globalThis[i]!==undefined){
@@ -365,6 +372,10 @@ if (hasCrypto) {
 knownGlobals.add(globalThis.SubtleCrypto);
 }
 
+if(hasLocalStorage){
+knownGlobals.add(globalThis.localStorage);
+}
+
 const{ Worker }=require('node:worker_threads');
 knownGlobals.add(Worker);
 
@@ -389,6 +400,11 @@ if (process.env.NODE_TEST_KNOWN_GLOBALS !== '0') {
 if(val==='crypto'&&!hasCrypto){
 continue;
 }
+// globalThis.localStorage is a getter that throws if Node.js was
+// executed without a --localstorage-file path.
+if(val==='localStorage'&&!hasLocalStorage){
+continue;
+}
 if(!knownGlobals.has(globalThis[val])){
 leaked.push(val);
 }
@@ -933,6 +949,7 @@ const common = {
  hasQuic,
  hasInspector,
  hasSQLite,
+ hasLocalStorage,
  invalidArgTypeHelper,
  isAlive,
  isASan,

test/common/index.mjs

@@ -19,6 +19,7 @@ const {
  hasQuic,
  hasInspector,
  hasSQLite,
+ hasLocalStorage,
  hasIntl,
  hasIPv6,
  isAIX,
@@ -71,6 +72,7 @@ export {
 hasQuic,
 hasInspector,
 hasSQLite,
+hasLocalStorage,
 hasIntl,
 hasIPv6,
 isAIX,

test/parallel/test-assert-checktag.js

@@ -1,5 +1,5 @@
 'use strict';
-const{ hasCrypto }=require('../common');
+const{ hasCrypto, hasLocalStorage}=require('../common');
 const{ test }=require('node:test');
 constassert=require('assert');
 
@@ -12,7 +12,7 @@ const assert = require('assert');
 if(process.stdout.isTTY)
 process.env.NODE_DISABLE_COLORS='1';
 
-test('',{skip: !hasCrypto},()=>{
+test({skip: !hasCrypto||!hasLocalStorage},()=>{
 // See https://github.com/nodejs/node/issues/10258
 {
 constdate=newDate('2016');

test/parallel/test-webstorage.js

@@ -41,13 +41,13 @@ test('sessionStorage is not persisted', async () => {
 assert.strictEqual((awaitreaddir(tmpdir.path)).length,0);
 });
 
-test('localStorage emits a warning when used without --localstorage-file',async()=>{
+test('localStorage throws without --localstorage-file',async()=>{
 constcp=awaitspawnPromisified(process.execPath,[
-'-pe','localStorage.length',
+'-e','localStorage',
 ]);
-assert.strictEqual(cp.code,0);
+assert.strictEqual(cp.code,1);
 assert.strictEqual(cp.signal,null);
-assert.match(cp.stderr,/Warning:`--localstorage-file`wasprovidedwithoutavalidpath/);
+assert.match(cp.stderr,/SecurityError:/);
 });
 
 test('localStorage is not persisted if it is unused',async()=>{