events: refactor to use more primordials

PR-URL: #36304
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: aduh95

lib/events.js

@@ -22,10 +22,13 @@
 'use strict';
 
 const{
+ ArrayPrototypeForEach,
  ArrayPrototypePush,
+ ArrayPrototypeSlice,
  Boolean,
  Error,
  ErrorCaptureStackTrace,
+ FunctionPrototypeCall,
  MathMin,
  NumberIsNaN,
  ObjectCreate,
@@ -81,7 +84,7 @@ const lazyDOMException = hideStackFrames((message, name) => {
 
 
 functionEventEmitter(opts){
-EventEmitter.init.call(this,opts);
+FunctionPrototypeCall(EventEmitter.init,this,opts);
 }
 module.exports=EventEmitter;
 module.exports.once=once;
@@ -173,7 +176,7 @@ EventEmitter.setMaxListeners =
 isEventTarget=require('internal/event_target').isEventTarget;
 
 // Performance for forEach is now comparable with regular for-loop
-eventTargets.forEach((target)=>{
+ArrayPrototypeForEach(eventTargets,(target)=>{
 if(isEventTarget(target)){
 target[kMaxEventTargetListeners]=n;
 target[kMaxEventTargetListenersWarned]=false;
@@ -224,7 +227,7 @@ function addCatch(that, promise, type, args) {
 constthen=promise.then;
 
 if(typeofthen==='function'){
-then.call(promise,undefined,function(err){
+FunctionPrototypeCall(then,promise,undefined,function(err){
 // The callback is called with nextTick to avoid a follow-up
 // rejection from this promise.
 process.nextTick(emitUnhandledRejectionOrErr,that,err,type,args);
@@ -670,7 +673,7 @@ function arrayClone(arr) {
 case5: return[arr[0],arr[1],arr[2],arr[3],arr[4]];
 case6: return[arr[0],arr[1],arr[2],arr[3],arr[4],arr[5]];
 }
-returnarr.slice();
+returnArrayPrototypeSlice(arr);
 }
 
 functionunwrapListeners(arr){
@@ -839,7 +842,7 @@ function on(emitter, event, options) {
 
 // Wait until an event happens
 returnnewPromise(function(resolve,reject){
-unconsumedPromises.push({ resolve, reject });
+ArrayPrototypePush(unconsumedPromises,{ resolve, reject });
 });
 },
 
@@ -903,7 +906,7 @@ function on(emitter, event, options) {
 if(promise){
 promise.resolve(createIterResult(args,false));
 }else{
-unconsumedEvents.push(args);
+ArrayPrototypePush(unconsumedEvents,args);
 }
 }
 

lib/internal/event_target.js

@@ -4,6 +4,8 @@ const {
  ArrayFrom,
  Boolean,
  Error,
+ FunctionPrototypeBind,
+ FunctionPrototypeCall,
  NumberIsInteger,
  ObjectAssign,
  ObjectDefineProperties,
@@ -208,7 +210,7 @@ class Listener {
 this.callback=
 typeoflistener==='function' ?
 listener :
-listener.handleEvent.bind(listener);
+FunctionPrototypeBind(listener.handleEvent,listener);
 }
 
 same(listener,capture){
@@ -396,7 +398,7 @@ class EventTarget {
 }else{
 arg=createEvent();
 }
-constresult=handler.callback.call(this,arg);
+constresult=FunctionPrototypeCall(handler.callback,this,arg);
 if(result!==undefined&&result!==null)
 addCatch(this,result,createEvent());
 }catch(err){
@@ -566,7 +568,7 @@ function isEventTarget(obj) {
 functionaddCatch(that,promise,event){
 constthen=promise.then;
 if(typeofthen==='function'){
-then.call(promise,undefined,function(err){
+FunctionPrototypeCall(then,promise,undefined,function(err){
 // The callback is called with nextTick to avoid a follow-up
 // rejection from this promise.
 process.nextTick(emitUnhandledRejectionOrErr,that,err,event);

lib/trace_events.js

@@ -2,7 +2,8 @@
 
 const{
  ArrayIsArray,
- Set,
+ ArrayPrototypeJoin,
+ SafeSet,
  Symbol,
 }=primordials;
 
@@ -27,7 +28,7 @@ const { CategorySet, getEnabledCategories } = internalBinding('trace_events');
 const{ customInspectSymbol }=require('internal/util');
 const{ format }=require('internal/util/inspect');
 
-constenabledTracingObjects=newSet();
+constenabledTracingObjects=newSafeSet();
 
 classTracing{
 constructor(categories){
@@ -63,7 +64,7 @@ class Tracing {
 }
 
 getcategories(){
-returnthis[kCategories].join(',');
+returnArrayPrototypeJoin(this[kCategories],',');
 }
 
 [customInspectSymbol](depth,opts){