Skip to content

Commit 50005e7

Browse files
gengjiawenrvagg
authored andcommitted
console: improve code readability
use object spread to make console code more readable PR-URL: #24412 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 1f54499 commit 50005e7

1 file changed

Lines changed: 16 additions & 13 deletions

File tree

‎lib/console.js‎

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -93,23 +93,26 @@ function Console(options /* or: stdout, stderr, ignoreErrors = true */) {
9393
thrownewERR_CONSOLE_WRITABLE_STREAM('stderr');
9494
}
9595

96-
varprop={
96+
constprop={
9797
writable: true,
9898
enumerable: false,
9999
configurable: true
100100
};
101-
prop.value=stdout;
102-
Object.defineProperty(this,'_stdout',prop);
103-
prop.value=stderr;
104-
Object.defineProperty(this,'_stderr',prop);
105-
prop.value=Boolean(ignoreErrors);
106-
Object.defineProperty(this,'_ignoreErrors',prop);
107-
prop.value=newMap();
108-
Object.defineProperty(this,'_times',prop);
109-
prop.value=createWriteErrorHandler(stdout);
110-
Object.defineProperty(this,'_stdoutErrorHandler',prop);
111-
prop.value=createWriteErrorHandler(stderr);
112-
Object.defineProperty(this,'_stderrErrorHandler',prop);
101+
Object.defineProperty(this,'_stdout',{ ...prop,value: stdout});
102+
Object.defineProperty(this,'_stderr',{ ...prop,value: stderr});
103+
Object.defineProperty(this,'_ignoreErrors',{
104+
...prop,
105+
value: Boolean(ignoreErrors),
106+
});
107+
Object.defineProperty(this,'_times',{ ...prop,value: newMap()});
108+
Object.defineProperty(this,'_stdoutErrorHandler',{
109+
...prop,
110+
value: createWriteErrorHandler(stdout),
111+
});
112+
Object.defineProperty(this,'_stderrErrorHandler',{
113+
...prop,
114+
value: createWriteErrorHandler(stderr),
115+
});
113116

114117
if(typeofcolorMode!=='boolean'&&colorMode!=='auto')
115118
thrownewERR_INVALID_ARG_VALUE('colorMode',colorMode);

0 commit comments

Comments
 (0)