http: make HEAD method to work with keep-alive

Fixes: #28438
PR-URL: #34231
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: josephhackman

lib/_http_outgoing.js

@@ -445,7 +445,8 @@ function _storeHeader(firstLine, headers) {
 }
 
 if(!state.contLen&&!state.te){
-if(!this._hasBody){
+if(!this._hasBody&&(this.statusCode===204||
+this.statusCode===304)){
 // Make sure we don't end the 0\r\n\r\n at the end of the message.
 this.chunkedEncoding=false;
 }elseif(!this.useChunkedEncodingByDefault){

test/parallel/test-http-reuse-socket.js

@@ -0,0 +1,51 @@
+'use strict';
+constcommon=require('../common');
+consthttp=require('http');
+constassert=require('assert');
+constCountdown=require('../common/countdown');
+
+// The HEAD:204, GET:200 is the most pathological test case.
+// GETs following a 204 response with a content-encoding header failed.
+// Responses without bodies and without content-length or encoding caused
+// the socket to be closed.
+constcodes=[204,200,200,304,200];
+constmethods=['HEAD','HEAD','GET','HEAD','GET'];
+
+constsockets=[];
+constagent=newhttp.Agent();
+agent.maxSockets=1;
+
+constcountdown=newCountdown(codes.length,()=>server.close());
+
+constserver=http.createServer(common.mustCall((req,res)=>{
+constcode=codes.shift();
+assert.strictEqual(typeofcode,'number');
+assert.ok(code>0);
+res.writeHead(code,{});
+res.end();
+},codes.length));
+
+functionnextRequest(){
+constrequest=http.request({
+port: server.address().port,
+path: '/',
+agent: agent,
+method: methods.shift()
+},common.mustCall((response)=>{
+response.on('end',common.mustCall(()=>{
+if(countdown.dec()){
+nextRequest();
+}
+assert.strictEqual(sockets.length,1);
+}));
+response.resume();
+}));
+request.on('socket',common.mustCall((socket)=>{
+if(!sockets.includes(socket)){
+sockets.push(socket);
+}
+}));
+request.end();
+}
+
+server.listen(0,common.mustCall(nextRequest));