test: refactor net-connect-handle-econnrefused

lpinca · targos · commit 50732c1b3f2c · 2019-04-27T11:36:09.000+02:00
- Remove unneeded server - Use `common.PORT` PR-URL: #27014 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/test/sequential/test-net-connect-handle-econnrefused.js b/test/sequential/test-net-connect-handle-econnrefused.js
@@ -24,13 +24,8 @@ const common = require('../common');
 const net = require('net');
 const assert = require('assert');
 
-const server = net.createServer();
-server.listen(0);
-const port = server.address().port;
-server.close(common.mustCall(() => {
- const c = net.createConnection(port);
- c.on('connect', common.mustNotCall());
- c.on('error', common.mustCall((e) => {
- assert.strictEqual(e.code, 'ECONNREFUSED');
- }));
+const c = net.createConnection(common.PORT);
+c.on('connect', common.mustNotCall());
+c.on('error', common.mustCall((e) => {
+ assert.strictEqual(e.code, 'ECONNREFUSED');
 }));

-Original file line number
+Diff line change
 constnet=require('net');
 constassert=require('assert');
 -constserver=net.createServer();
 -server.listen(0);
 -constport=server.address().port;
 -server.close(common.mustCall(()=>{
 -constc=net.createConnection(port);
 -c.on('connect',common.mustNotCall());
 -c.on('error',common.mustCall((e)=>{
 -assert.strictEqual(e.code,'ECONNREFUSED');
 -}));
 +constc=net.createConnection(common.PORT);
 +c.on('connect',common.mustNotCall());
 +c.on('error',common.mustCall((e)=>{
 +assert.strictEqual(e.code,'ECONNREFUSED');
 }));