lib: fix timer leak

PR-URL: #53337Fixes: #53335
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>

Author: theanarkh

lib/internal/timers.js

@@ -152,6 +152,11 @@ const timerListQueue = new PriorityQueue(compareTimersLists, setPosition);
 // - value = linked list
 consttimerListMap={__proto__: null};
 
+// This stores all the known timer async ids to allow users to clearTimeout and
+// clearInterval using those ids, to match the spec and the rest of the web
+// platform.
+constknownTimersById={__proto__: null};
+
 functioninitAsyncResource(resource,type){
 constasyncId=resource[async_id_symbol]=newAsyncId();
 consttriggerAsyncId=
@@ -550,6 +555,9 @@ function getTimerCallbacks(runNextTicks) {
 if(!timer._destroyed){
 timer._destroyed=true;
 
+if(timer[kHasPrimitive])
+deleteknownTimersById[asyncId];
+
 if(timer[kRefed])
 timeoutInfo[0]--;
 
@@ -580,6 +588,9 @@ function getTimerCallbacks(runNextTicks) {
 }elseif(!timer._idleNext&&!timer._idlePrev&&!timer._destroyed){
 timer._destroyed=true;
 
+if(timer[kHasPrimitive])
+deleteknownTimersById[asyncId];
+
 if(timer[kRefed])
 timeoutInfo[0]--;
 
@@ -683,4 +694,5 @@ module.exports = {
  timerListQueue,
  decRefCount,
  incRefCount,
+ knownTimersById,
 };

lib/timers.js

@@ -52,6 +52,7 @@ const {
  active,
  unrefActive,
  insert,
+ knownTimersById,
 }=require('internal/timers');
 const{
 promisify: {custom: customPromisify},
@@ -71,11 +72,6 @@ const {
  emitDestroy,
 }=require('internal/async_hooks');
 
-// This stores all the known timer async ids to allow users to clearTimeout and
-// clearInterval using those ids, to match the spec and the rest of the web
-// platform.
-constknownTimersById={__proto__: null};
-
 // Remove a timer. Cancels the timeout and resets the relevant timer properties.
 functionunenroll(item){
 if(item._destroyed)

test/fixtures/source-map/output/source_map_throw_set_immediate.snapshot

@@ -6,6 +6,6 @@
 Error: goodbye
  at Hello (*uglify-throw-original.js:5:9)
  at Immediate.<anonymous> (*uglify-throw-original.js:9:3)
- at process.processImmediate (node:internal*timers:478:21)
+ at process.processImmediate (node:internal*timers:483:21)
 
 Node.js *

test/parallel/test-primitive-timer-leak.js

@@ -0,0 +1,23 @@
+'use strict';
+// Flags: --expose-gc
+require('../common');
+constonGC=require('../common/ongc');
+
+// See https://github.com/nodejs/node/issues/53335
+constpoller=setInterval(()=>{
+global.gc();
+},100);
+
+letcount=0;
+
+for(leti=0;i<10;i++){
+consttimer=setTimeout(()=>{},0);
+onGC(timer,{
+ongc: ()=>{
+if(++count===10){
+clearInterval(poller);
+}
+}
+});
+console.log(+timer);
+}