src: apply multiple general cleanups to permissions

Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #65158
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Author: jasnell

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;

src/env.cc

@@ -954,6 +954,7 @@ Environment::Environment(IsolateData* isolate_data,
 
 if (options_->permission || options_->permission_audit) {
 permission()->EnablePermissions();
+staticconst std::array args = {std::string("*")};
 if (options_->permission_audit) {
 permission()->EnableWarningOnly();
  }
@@ -962,29 +963,29 @@ Environment::Environment(IsolateData* isolate_data,
 // unless explicitly allowed by the user
 if (!options_->allow_addons) {
  options_->allow_native_addons = false;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kAddon);
+permission()->Apply(this, args, permission::PermissionScope::kAddon);
  }
 if (!options_->allow_inspector) {
  flags_ = flags_ | EnvironmentFlags::kNoCreateInspector;
-permission()->Apply(this, {"*"}, permission::PermissionScope::kInspector);
+permission()->Apply(this, args, permission::PermissionScope::kInspector);
  }
 if (!options_->allow_child_process) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kChildProcess);
+this, args, permission::PermissionScope::kChildProcess);
  }
 if (!options_->allow_ffi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kFFI);
+permission()->Apply(this, args, permission::PermissionScope::kFFI);
  }
 if (!options_->allow_openssl_store) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kOpenSSLStore);
+this, args, permission::PermissionScope::kOpenSSLStore);
  }
 if (!options_->allow_worker_threads) {
 permission()->Apply(
-this, {"*"}, permission::PermissionScope::kWorkerThreads);
+this, args, permission::PermissionScope::kWorkerThreads);
  }
 if (!options_->allow_wasi) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kWASI);
+permission()->Apply(this, args, permission::PermissionScope::kWASI);
  }
 
 // Implicit allow entrypoint to kFileSystemRead
@@ -1019,7 +1020,7 @@ Environment::Environment(IsolateData* isolate_data,
  }
 
 if (options_->allow_net) {
-permission()->Apply(this, {"*"}, permission::PermissionScope::kNet);
+permission()->Apply(this, args, permission::PermissionScope::kNet);
  }
  }
 }

src/node_diagnostics_channel.cc

@@ -223,8 +223,8 @@ BaseObjectPtr<Channel> Channel::Get(Environment* env, std::string_view name) {
  HandleScope handle_scope(isolate);
  Local<Context> context = env->context();
  Local<Value> argv[] = {
-ToV8Value(context, name).ToLocalChecked(),
-Integer::NewFromUnsigned(isolate, index),
+ToV8Value(context, name).ToLocalChecked(),
+Integer::NewFromUnsigned(isolate, index),
  };
  Local<Value> result;
 if (binding->link_callback_.Get(isolate)

src/permission/addon_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 // Currently, Addon manage a single state
 // Once denied, it's always denied
 voidAddonPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidAddonPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolAddonPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/addon_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classAddonPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/child_process_permission.cc

@@ -10,20 +10,20 @@ namespace permission {
 // Currently, ChildProcess manage a single state
 // Once denied, it's always denied
 voidChildProcessPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidChildProcessPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolChildProcessPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return deny_all_ == false;
 }
 

src/permission/child_process_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classChildProcessPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_;

src/permission/ffi_permission.cc

@@ -9,20 +9,20 @@ namespace permission {
 
 // Currently, FFIPermission manages a single global deny state for FFI.
 voidFFIPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
  deny_all_ = true;
 }
 
 voidFFIPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
  deny_all_ = true;
 }
 
 boolFFIPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) const {
+ std::string_view param) const {
 return perm != PermissionScope::kFFI || !deny_all_;
 }
 

src/permission/ffi_permission.h

@@ -13,14 +13,14 @@ namespace permission {
 classFFIPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") constoverride;
+ std::string_view param) constoverride;
 
 private:
 bool deny_all_ = false;

src/permission/fs_permission.cc

@@ -52,7 +52,7 @@ void FreeRecursivelyNode(
 boolis_tree_granted(
  node::Environment* env,
 const node::permission::FSPermission::RadixTree* granted_tree,
-conststd::string_view& param) {
+ std::string_view param) {
  std::string resolved_param = node::PathResolve(env, {param});
 #ifdef _WIN32
 // Remove leading "\\?\" from UNC path
@@ -137,7 +137,7 @@ namespace permission {
 // allow = '*'
 // allow = '/tmp/,/home/example.js'
 voidFSPermission::Apply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) {
 for (const std::string& res : allow) {
 if (res == "*") {
@@ -156,7 +156,7 @@ void FSPermission::Apply(Environment* env,
 
 voidFSPermission::Drop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param) {
+ std::string_view param) {
 if (param.empty()) {
 // Drop all access for this scope
 if (scope == PermissionScope::kFileSystemRead ||
@@ -250,7 +250,7 @@ void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
 
 boolFSPermission::is_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param = "") const {
+ std::string_view param = "") const {
 switch (perm) {
 case PermissionScope::kFileSystem:
 return allow_all_in_ && allow_all_out_;
@@ -287,7 +287,7 @@ void FSPermission::RadixTree::Clear() {
  root_node_->is_leaf = false;
 }
 
-boolFSPermission::RadixTree::Lookup(conststd::string_view& s,
+boolFSPermission::RadixTree::Lookup(std::string_view s,
 bool when_empty_return) const {
  FSPermission::RadixTree::Node* current_node = root_node_;
 if (current_node->children.empty()) {

src/permission/fs_permission.h

@@ -16,14 +16,14 @@ namespace permission {
 classFSPermissionfinal : public PermissionBase {
 public:
 voidApply(Environment* env,
-conststd::vector<std::string>& allow,
+ std::span<conststd::string> allow,
  PermissionScope scope) override;
 voidDrop(Environment* env,
  PermissionScope scope,
-conststd::string_view& param = "") override;
+ std::string_view param) override;
 boolis_granted(Environment* env,
  PermissionScope perm,
-conststd::string_view& param) constoverride;
+ std::string_view param) constoverride;
 
 structRadixTree {
 structNode {
@@ -146,8 +146,8 @@ class FSPermission final : public PermissionBase {
 ~RadixTree();
 voidInsert(const std::string& s);
 voidClear();
-boolLookup(conststd::string_view& s) const { returnLookup(s, false); }
-boolLookup(conststd::string_view& s, bool when_empty_return) const;
+boolLookup(std::string_view s) const { returnLookup(s, false); }
+boolLookup(std::string_view s, bool when_empty_return) const;
 
 private:
  Node* root_node_;