stream: use more accurate end-of-stream writable and readable detection

The value of stream.readable and stream.writable should not
be used to detect whether a stream is Writable or Readable.
Refs: #29395
PR-URL: #29409
Backport-PR-URL: #31345
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: Stewart Addison

lib/internal/streams/end-of-stream.js

@@ -13,6 +13,18 @@ function isRequest(stream) {
 returnstream.setHeader&&typeofstream.abort==='function';
 }
 
+functionisReadable(stream){
+returntypeofstream.readable==='boolean'||
+typeofstream.readableEnded==='boolean'||
+!!stream._readableState;
+}
+
+functionisWritable(stream){
+returntypeofstream.writable==='boolean'||
+typeofstream.writableEnded==='boolean'||
+!!stream._writableState;
+}
+
 functioneos(stream,opts,callback){
 if(arguments.length===2){
 callback=opts;
@@ -28,8 +40,10 @@ function eos(stream, opts, callback) {
 
 callback=once(callback);
 
-letreadable=opts.readable||(opts.readable!==false&&stream.readable);
-letwritable=opts.writable||(opts.writable!==false&&stream.writable);
+letreadable=opts.readable||
+(opts.readable!==false&&isReadable(stream));
+letwritable=opts.writable||
+(opts.writable!==false&&isWritable(stream));
 
 constonlegacyfinish=()=>{
 if(!stream.writable)onfinish();

test/parallel/test-stream-finished.js

@@ -184,3 +184,52 @@ const { promisify } = require('util');
 finished(streamLike,common.mustCall);
 streamLike.emit('close');
 }
+
+
+{
+// Test is readable check through readable
+conststreamLike=newEE();
+streamLike.readable=false;
+finished(streamLike,common.mustCall());
+streamLike.emit('end');
+}
+
+{
+// Test is readable check through readableEnded
+conststreamLike=newEE();
+streamLike.readableEnded=true;
+finished(streamLike,common.mustCall());
+streamLike.emit('end');
+}
+
+{
+// Test is readable check through _readableState
+conststreamLike=newEE();
+streamLike._readableState={};
+finished(streamLike,common.mustCall());
+streamLike.emit('end');
+}
+
+{
+// Test is writable check through writable
+conststreamLike=newEE();
+streamLike.writable=false;
+finished(streamLike,common.mustCall());
+streamLike.emit('finish');
+}
+
+{
+// Test is writable check through writableEnded
+conststreamLike=newEE();
+streamLike.writableEnded=true;
+finished(streamLike,common.mustCall());
+streamLike.emit('finish');
+}
+
+{
+// Test is writable check through _writableState
+conststreamLike=newEE();
+streamLike._writableState={};
+finished(streamLike,common.mustCall());
+streamLike.emit('finish');
+}