Revert "stream: fix async iterator destroyed error propagation"

This reverts commit d15b8ea.
PR-URL: #31508
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: mcollina

lib/internal/streams/async_iterator.js

@@ -114,20 +114,18 @@ const ReadableStreamAsyncIteratorPrototype = ObjectSetPrototypeOf({
 }
 
 if(this[kStream].destroyed){
+// We need to defer via nextTick because if .destroy(err) is
+// called, the error will be emitted via nextTick, and
+// we cannot guarantee that there is no error lingering around
+// waiting to be emitted.
 returnnewPromise((resolve,reject)=>{
-if(this[kError]){
-reject(this[kError]);
-}elseif(this[kEnded]){
-resolve(createIterResult(undefined,true));
-}else{
-finished(this[kStream],(err)=>{
-if(err&&err.code!=='ERR_STREAM_PREMATURE_CLOSE'){
-reject(err);
-}else{
-resolve(createIterResult(undefined,true));
-}
-});
-}
+process.nextTick(()=>{
+if(this[kError]){
+reject(this[kError]);
+}else{
+resolve(createIterResult(undefined,true));
+}
+});
 });
 }
 

test/parallel/test-stream-readable-async-iterators.js

@@ -567,23 +567,6 @@ async function tests() {
 assert.strictEqual(e,err);
 })()]);
 }
-
-{
-const_err=newError('asd');
-constr=newReadable({
-read(){
-},
-destroy(err,callback){
-setTimeout(()=>callback(_err),1);
-}
-});
-
-r.destroy();
-constit=r[Symbol.asyncIterator]();
-it.next().catch(common.mustCall((err)=>{
-assert.strictEqual(err,_err);
-}));
-}
 }
 
 {