module: update tests for combined ambiguous module syntax error

PR-URL: #55874Fixes: #55776
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Author: mertcanaltin

lib/internal/modules/esm/module_job.js

@@ -73,9 +73,16 @@ const isCommonJSGlobalLikeNotDefinedError = (errorMessage) =>
  * @param {string} url
  * @returns {void}
  */
-constexplainCommonJSGlobalLikeNotDefinedError=(e,url)=>{
+constexplainCommonJSGlobalLikeNotDefinedError=(e,url,hasTopLevelAwait)=>{
 if(e?.name==='ReferenceError'&&
 isCommonJSGlobalLikeNotDefinedError(e.message)){
+
+if(hasTopLevelAwait){
+e.message=`Cannot determine intended module format because both require() and top-level await are present. If the code is intended to be CommonJS, wrap await in an async function. If the code is intended to be an ES module, replace require() with import.`;
+e.code='ERR_AMBIGUOUS_MODULE_SYNTAX';
+return;
+}
+
 e.message+=' in ES module scope';
 
 if(StringPrototypeStartsWith(e.message,'require ')){
@@ -335,7 +342,7 @@ class ModuleJob extends ModuleJobBase {
 try{
 awaitthis.module.evaluate(timeout,breakOnSigint);
 }catch(e){
-explainCommonJSGlobalLikeNotDefinedError(e,this.module.url);
+explainCommonJSGlobalLikeNotDefinedError(e,this.module.url,this.module.hasTopLevelAwait());
 throwe;
 }
 return{__proto__: null,module: this.module};
@@ -443,7 +450,7 @@ class ModuleJobSync extends ModuleJobBase {
 constnamespace=this.module.evaluateSync(filename,parentFilename);
 return{__proto__: null,module: this.module, namespace };
 }catch(e){
-explainCommonJSGlobalLikeNotDefinedError(e,this.module.url);
+explainCommonJSGlobalLikeNotDefinedError(e,this.module.url,this.module.hasTopLevelAwait());
 throwe;
 }
 }

src/module_wrap.cc

@@ -824,6 +824,27 @@ void ModuleWrap::IsGraphAsync(const FunctionCallbackInfo<Value>& args) {
  args.GetReturnValue().Set(module->IsGraphAsync());
 }
 
+voidModuleWrap::HasTopLevelAwait(const FunctionCallbackInfo<Value>& args) {
+ Isolate* isolate = args.GetIsolate();
+ ModuleWrap* obj;
+ASSIGN_OR_RETURN_UNWRAP(&obj, args.This());
+
+ Local<Module> module = obj->module_.Get(isolate);
+
+// Check if module is valid
+if (module.IsEmpty()) {
+ args.GetReturnValue().Set(false);
+return;
+ }
+
+// For source text modules, check if the graph is async
+// For synthetic modules, it's always false
+bool has_top_level_await =
+module->IsSourceTextModule() && module->IsGraphAsync();
+
+ args.GetReturnValue().Set(has_top_level_await);
+}
+
 voidModuleWrap::GetError(const FunctionCallbackInfo<Value>& args) {
  Isolate* isolate = args.GetIsolate();
  ModuleWrap* obj;
@@ -1181,6 +1202,8 @@ void ModuleWrap::CreatePerIsolateProperties(IsolateData* isolate_data,
 SetProtoMethodNoSideEffect(isolate, tpl, "getNamespace", GetNamespace);
 SetProtoMethodNoSideEffect(isolate, tpl, "getStatus", GetStatus);
 SetProtoMethodNoSideEffect(isolate, tpl, "isGraphAsync", IsGraphAsync);
+SetProtoMethodNoSideEffect(
+ isolate, tpl, "hasTopLevelAwait", HasTopLevelAwait);
 SetProtoMethodNoSideEffect(isolate, tpl, "getError", GetError);
 SetConstructorFunction(isolate, target, "ModuleWrap", tpl);
  isolate_data->set_module_wrap_constructor_template(tpl);
@@ -1238,6 +1261,7 @@ void ModuleWrap::RegisterExternalReferences(
  registry->Register(GetStatus);
  registry->Register(GetError);
  registry->Register(IsGraphAsync);
+ registry->Register(HasTopLevelAwait);
 
  registry->Register(CreateRequiredModuleFacade);
 

src/module_wrap.h

@@ -58,6 +58,7 @@ class ModuleWrap : public BaseObject {
 voidMemoryInfo(MemoryTracker* tracker) constoverride {
  tracker->TrackField("resolve_cache", resolve_cache_);
  }
+staticvoidHasTopLevelAwait(const v8::FunctionCallbackInfo<v8::Value>& args);
 
  v8::Local<v8::Context> context() const;
  v8::Maybe<bool> CheckUnsettledTopLevelAwait();

test/es-module/test-esm-detect-ambiguous.mjs

@@ -294,7 +294,10 @@ describe('Module syntax detection', { concurrency: !process.env.TEST_PARALLEL },
 'const fs = require("node:fs"); await Promise.resolve();',
 ]);
 
-match(stderr,/ReferenceError:requireisnotdefinedinESmodulescope/);
+match(
+stderr,
+/ReferenceError:Cannotdetermineintendedmoduleformatbecausebothrequire\(\)andtop-levelawaitarepresent\.IfthecodeisintendedtobeCommonJS,wrapawaitinanasyncfunction\.IfthecodeisintendedtobeanESmodule,replacerequire\(\)withimport\./
+);
 strictEqual(stdout,'');
 strictEqual(code,1);
 strictEqual(signal,null);
@@ -436,3 +439,24 @@ describe('when working with Worker threads', () => {
 strictEqual(signal,null);
 });
 });
+
+describe('cjs & esm ambiguous syntax case',()=>{
+it('should throw an ambiguous syntax error when using top-level await with require',async()=>{
+const{ stderr, code, signal }=awaitspawnPromisified(
+process.execPath,
+[
+'--input-type=module',
+'--eval',
+`await 1;\nconst fs = require('fs');`,
+]
+);
+
+match(
+stderr,
+/ReferenceError:Cannotdetermineintendedmoduleformatbecausebothrequire\(\)andtop-levelawaitarepresent\.IfthecodeisintendedtobeCommonJS,wrapawaitinanasyncfunction\.IfthecodeisintendedtobeanESmodule,replacerequire\(\)withimport\./
+);
+
+strictEqual(code,1);
+strictEqual(signal,null);
+});
+});