http: remove 'data' and 'end' listener if client parser error

There might be the case of some more data coming through after
the parser has returned an error and we have destroyed the socket.
We should also be removing the 'data' event handler.
Fixes: #40242
PR-URL: #40244
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: mcollina

lib/_http_client.js

@@ -489,6 +489,8 @@ function socketOnData(d) {
 prepareError(ret,parser,d);
 debug('parse error',ret);
 freeParser(parser,req,socket);
+socket.removeListener('data',socketOnData);
+socket.removeListener('end',socketOnEnd);
 socket.destroy();
 req.socket._hadError=true;
 req.emit('error',ret);

test/parallel/test-http-client-parse-error.js

@@ -23,6 +23,7 @@
 constcommon=require('../common');
 consthttp=require('http');
 constnet=require('net');
+constassert=require('assert');
 constCountdown=require('../common/countdown');
 
 constcountdown=newCountdown(2,()=>server.close());
@@ -38,10 +39,12 @@ const server =
 
 server.listen(0,common.mustCall(()=>{
 for(leti=0;i<2;i++){
-http.get({
+constreq=http.get({
 port: server.address().port,
 path: '/'
 }).on('error',common.mustCall((e)=>{
+assert.strictEqual(req.socket.listenerCount('data'),0);
+assert.strictEqual(req.socket.listenerCount('end'),1);
 common.expectsError({
 code: 'HPE_INVALID_CONSTANT',
 message: 'Parse Error: Expected HTTP/'