benchmark: refactor prims-and-objs-big-loop

Trott · MylesBorins · commit 56c67595db5d · 2018-06-06T10:31:28.000+02:00
This is a minor refactor of benchmark/assert/deepequal-prims-and-objs-big-loop.js to reduce exceptions that need to be made for lint compliance. PR-URL: #21030 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/benchmark/assert/deepequal-prims-and-objs-big-loop.js b/benchmark/assert/deepequal-prims-and-objs-big-loop.js
@@ -25,13 +25,14 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, primitive, method }) {
+ if (!method)
+ method = 'deepEqual';
 const prim = primValues[primitive];
 const actual = prim;
 const expected = prim;
 const expectedWrong = 'b';
 
- // eslint-disable-next-line no-restricted-properties
- const fn = method !== '' ? assert[method] : assert.deepEqual;
+ const fn = assert[method];
 const value2 = method.includes('not') ? expectedWrong : expected;
 
 bench.start();

-Original file line number
+Diff line change
 });
 functionmain({ n, primitive, method }){
 +if(!method)
 +method='deepEqual';
 constprim=primValues[primitive];
 constactual=prim;
 constexpected=prim;
 constexpectedWrong='b';
 -// eslint-disable-next-line no-restricted-properties
 -constfn=method!=='' ? assert[method] : assert.deepEqual;
 +constfn=assert[method];
 constvalue2=method.includes('not') ? expectedWrong : expected;
 bench.start();