tls: simplify enableTrace logic

cjihrig · targos · commit 576fe339a1fc · 2019-05-04T09:20:20.000+02:00
PR-URL: #27497 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/_tls_wrap.js b/lib/_tls_wrap.js
@@ -998,13 +998,12 @@ function Server(options, listener) {
 }
 
 const enableTrace = options.enableTrace;
- if (enableTrace === true)
- this[kEnableTrace] = true;
- else if (enableTrace === false || enableTrace == null)
- ; // Tracing explicitly disabled, or defaulting to disabled.
- else
+ if (typeof enableTrace === 'boolean') {
+ this[kEnableTrace] = enableTrace;
+ } else if (enableTrace != null) {
 throw new ERR_INVALID_ARG_TYPE(
 'options.enableTrace', 'boolean', enableTrace);
+ }
 }
 
 Object.setPrototypeOf(Server.prototype, net.Server.prototype);

-Original file line number
+Diff line change
+}
 constenableTrace=options.enableTrace;
 -if(enableTrace===true)
 -this[kEnableTrace]=true;
 -elseif(enableTrace===false||enableTrace==null)
 -;// Tracing explicitly disabled, or defaulting to disabled.
 -else
 +if(typeofenableTrace==='boolean'){
 +this[kEnableTrace]=enableTrace;
 +}elseif(enableTrace!=null){
 thrownewERR_INVALID_ARG_TYPE(
 'options.enableTrace','boolean',enableTrace);
 +}
+}
 Object.setPrototypeOf(Server.prototype,net.Server.prototype);