src: print backtrace on failed CHECK/ASSERT

Print a C backtrace on fatal errors to make it easier to debug issues.
PR-URL: #6734
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: bnoordhuis

src/node.cc

@@ -1795,6 +1795,31 @@ NO_RETURN void Abort() {
 }
 
 
+NO_RETURNvoidAssert(constchar* const (*args)[4]) {
+auto filename = (*args)[0];
+auto linenum = (*args)[1];
+auto message = (*args)[2];
+auto function = (*args)[3];
+
+char exepath[256];
+size_t exepath_size = sizeof(exepath);
+if (uv_exepath(exepath, &exepath_size))
+snprintf(exepath, sizeof(exepath), "node");
+
+char pid[12] = {0};
+#ifndef _WIN32
+snprintf(pid, sizeof(pid), "[%u]", getpid());
+#endif
+
+fprintf(stderr, "%s%s: %s:%s:%s%s Assertion `%s' failed.\n",
+ exepath, pid, filename, linenum,
+ function, *function ? ":" : "", message);
+fflush(stderr);
+
+Abort();
+}
+
+
 staticvoidAbort(const FunctionCallbackInfo<Value>& args) {
 Abort();
 }

src/util.h

@@ -25,7 +25,10 @@ namespace node {
 #defineNO_RETURN
 #endif
 
+// The slightly odd function signature for Assert() is to ease
+// instruction cache pressure in calls from ASSERT and CHECK.
 NO_RETURNvoidAbort();
+NO_RETURNvoidAssert(constchar* const (*args)[4]);
 voidDumpBacktrace(FILE* fp);
 
 #ifdef __APPLE__
@@ -52,15 +55,40 @@ template <typename T> using remove_reference = std::remove_reference<T>;
 
 #defineABORT() node::Abort()
 
-#if defined(NDEBUG)
-# defineASSERT(expression)
-# defineCHECK(expression) \
+#ifdef __GNUC__
+#defineLIKELY(expr) __builtin_expect(!!(expr), 1)
+#defineUNLIKELY(expr) __builtin_expect(!!(expr), 0)
+#definePRETTY_FUNCTION_NAME __PRETTY_FUNCTION__
+#else
+#defineLIKELY(expr) expr
+#defineUNLIKELY(expr) expr
+#definePRETTY_FUNCTION_NAME""
+#endif
+
+#defineSTRINGIFY_(x) #x
+#defineSTRINGIFY(x) STRINGIFY_(x)
+
+#defineCHECK(expr) \
 do { \
-if (!(expression)) ABORT(); \
+if (UNLIKELY(!(expr))) { \
+staticconstchar* const args[] = { __FILE__, STRINGIFY(__LINE__), \
+ #expr, PRETTY_FUNCTION_NAME }; \
+node::Assert(&args); \
+ } \
  } while (0)
+
+// FIXME(bnoordhuis) cctests don't link in node::Abort() and node::Assert().
+#ifdef GTEST_DONT_DEFINE_ASSERT_EQ
+#undef ABORT
+#undef CHECK
+#defineABORTABORT_NO_BACKTRACE
+#defineCHECKassert
+#endif
+
+#ifdef NDEBUG
+#defineASSERT(expr)
 #else
-# defineASSERT(expression) assert(expression)
-# defineCHECK(expression) assert(expression)
+#defineASSERT(expr) CHECK(expr)
 #endif
 
 #defineASSERT_EQ(a, b) ASSERT((a) == (b))