test: improve test coverage for child process message sending

juanarbol · ruyadorno · commit 5861135ddb3a · 2024-11-27T11:03:34.000-05:00
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #55710 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
diff --git a/test/parallel/test-child-process-send-type-error.js b/test/parallel/test-child-process-send-type-error.js
@@ -4,10 +4,10 @@ const common = require('../common');
 const assert = require('assert');
 const cp = require('child_process');
 
-function fail(proc, args) {
+function fail(proc, args, code = 'ERR_INVALID_ARG_TYPE') {
 assert.throws(() => {
 proc.send.apply(proc, args);
- }, { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError' });
+ }, { code, name: 'TypeError' });
 }
 
 let target = process;
@@ -25,5 +25,6 @@ fail(target, ['msg', null, '']);
 fail(target, ['msg', null, 'foo']);
 fail(target, ['msg', null, 0]);
 fail(target, ['msg', null, NaN]);
+fail(target, ['msg', 'meow', undefined], 'ERR_INVALID_HANDLE_TYPE');
 fail(target, ['msg', null, 1]);
 fail(target, ['msg', null, null, common.mustNotCall()]);

-Original file line number
+Diff line change
 constassert=require('assert');
 constcp=require('child_process');
 -functionfail(proc,args){
 +functionfail(proc,args,code='ERR_INVALID_ARG_TYPE'){
 assert.throws(()=>{
 proc.send.apply(proc,args);
 -},{code: 'ERR_INVALID_ARG_TYPE',name: 'TypeError'});
 +},{ code,name: 'TypeError'});
+}
 lettarget=process;
 fail(target,['msg',null,'foo']);
 fail(target,['msg',null,0]);
 fail(target,['msg',null,NaN]);
 +fail(target,['msg','meow',undefined],'ERR_INVALID_HANDLE_TYPE');
 fail(target,['msg',null,1]);
 fail(target,['msg',null,null,common.mustNotCall()]);