test: use mustCall() in pummel test

Trott · MylesBorins · commit 58dfeac13383 · 2020-07-16T17:09:13.000-04:00
Replace 'exit' check with common.mustCall(). PR-URL: #34327 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/pummel/test-net-connect-econnrefused.js b/test/pummel/test-net-connect-econnrefused.js
@@ -48,17 +48,14 @@ function pummel() {
 }
 
 function check() {
- setTimeout(function() {
+ setTimeout(common.mustCall(function() {
 assert.strictEqual(process._getActiveRequests().length, 0);
 const activeHandles = process._getActiveHandles();
 assert.ok(activeHandles.every((val) => val.constructor.name !== 'Socket'));
- check_called = true;
- }, 0);
+ }), 0);
 }
-let check_called = false;
 
 process.on('exit', function() {
 assert.strictEqual(rounds, ROUNDS);
 assert.strictEqual(reqs, ROUNDS * ATTEMPTS_PER_ROUND);
- assert(check_called);
 });

-Original file line number
+Diff line change
+}
 functioncheck(){
 -setTimeout(function(){
 +setTimeout(common.mustCall(function(){
 assert.strictEqual(process._getActiveRequests().length,0);
 constactiveHandles=process._getActiveHandles();
 assert.ok(activeHandles.every((val)=>val.constructor.name!=='Socket'));
 -check_called=true;
 -},0);
 +}),0);
+}
 -letcheck_called=false;
 process.on('exit',function(){
 assert.strictEqual(rounds,ROUNDS);
 assert.strictEqual(reqs,ROUNDS*ATTEMPTS_PER_ROUND);
 -assert(check_called);
 });