assert: fix line number calculation after V8 upgrade

targos · MylesBorins · commit 5981fb7faa13 · 2019-10-07T03:20:07.000-04:00
PR-URL: #29694 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
diff --git a/lib/assert.js b/lib/assert.js
@@ -269,7 +269,7 @@ function getErrMessage(message, fn) {
 const call = err.stack[0];
 
 const filename = call.getFileName();
- const line = call.getLineNumber() - 1;
+ let line = call.getLineNumber() - 1;
 let column = call.getColumnNumber() - 1;
 let identifier;
 let code;
@@ -289,6 +289,9 @@ function getErrMessage(message, fn) {
 return message;
 }
 code = String(fn);
+ // For functions created with the Function constructor, V8 does not count
+ // the lines containing the function header.
+ line += 2;
 identifier = `${code}${line}${column}`;
 }
 

-Original file line number
+Diff line change
 constcall=err.stack[0];
 constfilename=call.getFileName();
 -constline=call.getLineNumber()-1;
 +letline=call.getLineNumber()-1;
 letcolumn=call.getColumnNumber()-1;
 letidentifier;
 letcode;
 returnmessage;
+}
 code=String(fn);
 +// For functions created with the Function constructor, V8 does not count
 +// the lines containing the function header.
 +line+=2;
 identifier=`${code}${line}${column}`;
+}