perf_hooks: use for...of

trivikr · targos · commit 59e2975413d7 · 2020-01-14T16:56:22.000+01:00
PR-URL: #31049 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/perf_hooks.js b/lib/perf_hooks.js
@@ -322,12 +322,11 @@ class PerformanceObserver extends AsyncResource {
 disconnect() {
 const observerCountsGC = observerCounts[NODE_PERFORMANCE_ENTRY_TYPE_GC];
 const types = this[kTypes];
- const keys = ObjectKeys(types);
- for (var n = 0; n < keys.length; n++) {
- const item = types[keys[n]];
+ for (const key of ObjectKeys(types)) {
+ const item = types[key];
 if (item) {
 L.remove(item);
- observerCounts[keys[n]]--;
+ observerCounts[key]--;
 }
 }
 this[kTypes] = {};
@@ -353,8 +352,7 @@ class PerformanceObserver extends AsyncResource {
 this[kBuffer][kEntries] = [];
 L.init(this[kBuffer][kEntries]);
 this[kBuffering] = Boolean(options.buffered);
- for (var n = 0; n < entryTypes.length; n++) {
- const entryType = entryTypes[n];
+ for (const entryType of entryTypes) {
 const list = getObserversList(entryType);
 if (this[kTypes][entryType]) continue;
 const item = { obs: this };

-Original file line number
+Diff line change
 disconnect(){
 constobserverCountsGC=observerCounts[NODE_PERFORMANCE_ENTRY_TYPE_GC];
 consttypes=this[kTypes];
 -constkeys=ObjectKeys(types);
 -for(varn=0;n<keys.length;n++){
 -constitem=types[keys[n]];
 +for(constkeyofObjectKeys(types)){
 +constitem=types[key];
 if(item){
 L.remove(item);
 -observerCounts[keys[n]]--;
 +observerCounts[key]--;
+}
+}
 this[kTypes]={};
 this[kBuffer][kEntries]=[];
 L.init(this[kBuffer][kEntries]);
 this[kBuffering]=Boolean(options.buffered);
 -for(varn=0;n<entryTypes.length;n++){
 -constentryType=entryTypes[n];
 +for(constentryTypeofentryTypes){
 constlist=getObserversList(entryType);
 if(this[kTypes][entryType])continue;
 constitem={obs: this};