Skip to content

Commit 5ad3efb

Browse files
mcollinatargos
authored andcommitted
tls: implement capture rejections for 'secureConnection' event
PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 4eecee0 commit 5ad3efb

2 files changed

Lines changed: 48 additions & 0 deletions

File tree

‎lib/_tls_wrap.js‎

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ assertCrypto();
3737
const{ setImmediate }=require('timers');
3838
constassert=require('internal/assert');
3939
constcrypto=require('crypto');
40+
constEE=require('events');
4041
constnet=require('net');
4142
consttls=require('tls');
4243
constcommon=require('_tls_common');
@@ -1284,6 +1285,19 @@ Server.prototype.addContext = function(servername, context) {
12841285
this._contexts.push([re,tls.createSecureContext(context).context]);
12851286
};
12861287

1288+
Server.prototype[EE.captureRejectionSymbol]=function(
1289+
err,event,sock){
1290+
1291+
switch(event){
1292+
case'secureConnection':
1293+
sock.destroy(err);
1294+
break;
1295+
default:
1296+
net.Server.prototype[Symbol.for('nodejs.rejection')]
1297+
.call(this,err,event,sock);
1298+
}
1299+
};
1300+
12871301
functionSNICallback(servername,callback){
12881302
constcontexts=this.server._contexts;
12891303

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
'use strict';
2+
3+
constcommon=require('../common');
4+
if(!common.hasCrypto)
5+
common.skip('missing crypto');
6+
7+
constassert=require('assert');
8+
constevents=require('events');
9+
constfixtures=require('../common/fixtures');
10+
const{ createServer, connect }=require('tls');
11+
constcert=fixtures.readKey('rsa_cert.crt');
12+
constkey=fixtures.readKey('rsa_private.pem');
13+
14+
events.captureRejections=true;
15+
16+
constserver=createServer({ cert, key },common.mustCall(async(sock)=>{
17+
server.close();
18+
19+
const_err=newError('kaboom');
20+
sock.on('error',common.mustCall((err)=>{
21+
assert.strictEqual(err,_err);
22+
}));
23+
throw_err;
24+
}));
25+
26+
server.listen(0,common.mustCall(()=>{
27+
constsock=connect({
28+
port: server.address().port,
29+
host: server.address().host,
30+
rejectUnauthorized: false
31+
});
32+
33+
sock.on('close',common.mustCall());
34+
}));

0 commit comments

Comments
 (0)