assert: optimize partial comparison of two Sets

aduh95 · aduh95 · commit 5b0ce376a2d7 · 2024-11-26T15:34:32.000+01:00
PR-URL: #55970 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/assert.js b/lib/assert.js
@@ -414,33 +414,25 @@ function compareBranch(
 }
 
 // Check for Set object equality
- // TODO(aduh95): switch to `SetPrototypeIsSubsetOf` when it's available
 if (isSet(actual) && isSet(expected)) {
 if (expected.size > actual.size) {
 return false; // `expected` can't be a subset if it has more elements
 }
 
 if (isDeepEqual === undefined) lazyLoadComparison();
 
- const actualArray = ArrayFrom(actual);
- const expectedArray = ArrayFrom(expected);
+ const actualArray = ArrayFrom(FunctionPrototypeCall(SafeSet.prototype[SymbolIterator], actual));
+ const expectedIterator = FunctionPrototypeCall(SafeSet.prototype[SymbolIterator], expected);
 const usedIndices = new SafeSet();
 
- for (let expectedIdx = 0; expectedIdx < expectedArray.length; expectedIdx++) {
- const expectedItem = expectedArray[expectedIdx];
- let found = false;
-
+ expectedIteration: for (const expectedItem of expectedIterator) {
 for (let actualIdx = 0; actualIdx < actualArray.length; actualIdx++) {
 if (!usedIndices.has(actualIdx) && isDeepStrictEqual(actualArray[actualIdx], expectedItem)) {
 usedIndices.add(actualIdx);
- found = true;
- break;
+ continue expectedIteration;
 }
 }
-
- if (!found) {
- return false;
- }
+ return false;
 }
 
 return true;

-Original file line number
+Diff line change
+}
 // Check for Set object equality
 -// TODO(aduh95): switch to `SetPrototypeIsSubsetOf` when it's available
 if(isSet(actual)&&isSet(expected)){
 if(expected.size>actual.size){
 returnfalse;// `expected` can't be a subset if it has more elements
+}
 if(isDeepEqual===undefined)lazyLoadComparison();
 -constactualArray=ArrayFrom(actual);
 -constexpectedArray=ArrayFrom(expected);
 +constactualArray=ArrayFrom(FunctionPrototypeCall(SafeSet.prototype[SymbolIterator],actual));
 +constexpectedIterator=FunctionPrototypeCall(SafeSet.prototype[SymbolIterator],expected);
 constusedIndices=newSafeSet();
 -for(letexpectedIdx=0;expectedIdx<expectedArray.length;expectedIdx++){
 -constexpectedItem=expectedArray[expectedIdx];
 -letfound=false;
+-
 + expectedIteration: for(constexpectedItemofexpectedIterator){
 for(letactualIdx=0;actualIdx<actualArray.length;actualIdx++){
 if(!usedIndices.has(actualIdx)&&isDeepStrictEqual(actualArray[actualIdx],expectedItem)){
 usedIndices.add(actualIdx);
 -found=true;
 -break;
 +continue expectedIteration;
+}
+}
+-
 -if(!found){
 -returnfalse;
 -}
 +returnfalse;
+}
 returntrue;