build: add --verbose to ./configure

PR-URL: #22450
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Author: refack

configure.py

@@ -547,6 +547,12 @@
 default=False,
 help='build V8 using GN instead of gyp')
 
+parser.add_option('--verbose',
+action='store_true',
+dest='verbose',
+default=False,
+help='get more output from this script')
+
 # Create compile_commands.json in out/Debug and out/Release.
 parser.add_option('-C',
 action='store_true',
@@ -575,6 +581,14 @@ def warn(msg):
 # track if warnings occurred
 warn.warned=False
 
+defprint_verbose(x):
+ifnotoptions.verbose:
+return
+iftype(x) isstr:
+printx
+else:
+pprint.pprint(x, indent=2)
+
 defb(value):
 """Returns the string 'true' if value is truthy, 'false' otherwise."""
 ifvalue:
@@ -1158,7 +1172,7 @@ def without_ssl_error(option):
 defconfigure_static(o):
 ifoptions.fully_staticoroptions.partly_static:
 ifflavor=='mac':
-print("Generation of static executable will not work on OSX "
+warn("Generation of static executable will not work on OSX "
 "when using the default compilation environment")
 return
 
@@ -1172,9 +1186,9 @@ def configure_static(o):
 
 defwrite(filename, data):
 filename=filename
-print('creating %s'%filename)
-f=open(filename, 'w+')
-f.write(data)
+print_verbose('creating %s'%filename)
+withopen(filename, 'w+')asf:
+f.write(data)
 
 do_not_edit='# Do not edit. Generated by the configure script.\n'
 
@@ -1192,7 +1206,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir):
 patchfile='%s/%s/%s'% (dir_base, patch_dir, file)
 ifos.path.isfile(patchfile):
 srcfile='%s/%s'% (patch_dir, file)
-print('Using version-specific floating patch %s'%patchfile)
+warn('Using floating patch "%s" from "%s"'%(patchfile, dir_base))
 list.append(srcfile)
 break
 returnlist
@@ -1226,8 +1240,8 @@ def icu_download(path):
 if (md5==gotmd5):
 returntargetfile
 else:
-print('Expected: %s *MISMATCH*'%md5)
-print('\n ** Corrupted ZIP? Delete %s to retry download.\n'%targetfile)
+error('Expected: %s *MISMATCH*'%md5)
+error('\n ** Corrupted ZIP? Delete %s to retry download.\n'%targetfile)
 returnNone
 icu_config= {
 'variables': {}
@@ -1328,7 +1342,7 @@ def write_config(data, name):
 # --with-icu-source processing
 # now, check that they didn't pass --with-icu-source=deps/icu
 elifwith_icu_sourceandos.path.abspath(icu_full_path) ==os.path.abspath(with_icu_source):
-print('Ignoring redundant --with-icu-source=%s'%with_icu_source)
+warn('Ignoring redundant --with-icu-source=%s'%with_icu_source)
 with_icu_source=None
 # if with_icu_source is still set, try to use it.
 ifwith_icu_source:
@@ -1371,7 +1385,7 @@ def write_config(data, name):
 # ICU source dir relative to tools/icu (for .gyp file)
 o['variables']['icu_path'] =icu_full_path
 ifnotos.path.isdir(icu_full_path):
-print('* ECMA-402 (Intl) support didn\'t find ICU in %s..'%icu_full_path)
+warn('* ECMA-402 (Intl) support didn\'t find ICU in %s..'%icu_full_path)
 # can we download (or find) a zipfile?
 localzip=icu_download(icu_full_path)
 iflocalzip:
@@ -1380,7 +1394,7 @@ def write_config(data, name):
 error('''Cannot build Intl without ICU in %s.
  Fix, or disable with "--with-intl=none"'''%icu_full_path)
 else:
-print('* Using ICU in %s'%icu_full_path)
+print_verbose('* Using ICU in %s'%icu_full_path)
 # Now, what version of ICU is it? We just need the "major", such as 54.
 # uvernum.h contains it as a #define.
 uvernum_h=os.path.join(icu_full_path, 'source/common/unicode/uvernum.h')
@@ -1543,7 +1557,7 @@ def make_bin_override():
 ifmake_global_settings:
 output['make_global_settings'] =make_global_settings
 
-pprint.pprint(output, indent=2)
+print_verbose(output)
 
 write('config.gypi', do_not_edit+
 pprint.pformat(output, indent=2) +'\n')
@@ -1582,9 +1596,11 @@ def make_bin_override():
 ifoptions.compile_commands_json:
 gyp_args+= ['-f', 'compile_commands_json']
 
+# pass the leftover positional arguments to GYP
 gyp_args+=args
 
-ifwarn.warned:
+ifwarn.warnedandnotoptions.verbose:
 warn('warnings were emitted in the configure phase')
 
+print_verbose("running: \n "+" ".join(['python', 'tools/gyp_node.py'] +gyp_args))
 run_gyp(gyp_args)