Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit 5c9576b

Browse files
trivenayaduh95
authored andcommitted
quic: reset rejected HTTP/3 request streams with H3_REQUEST_REJECTED
An incoming HTTP/3 request stream rejected without any application processing (the session has no stream consumer) is now reset with H3_REQUEST_REJECTED so the peer learns the request was not processed, per RFC 9114 section 4.1.1. The code is surfaced per-application like the existing no-error and internal-error codes, so non-HTTP/3 applications are unchanged. Fixes: #65441 Signed-off-by: Naman Trivedi <trivenay@amazon.com> PR-URL: #65442 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c42fbcc commit 5c9576b

7 files changed

Lines changed: 96 additions & 1 deletion

File tree

β€Žlib/internal/quic/quic.jsβ€Ž

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4166,7 +4166,16 @@ class QuicSession {
41664166
// case rather than letting it hold flow control credit.
41674167
if(!this.#hasStreamConsumer()){
41684168
process.emitWarning('A new stream was received but no stream consumer callback was provided');
4169-
stream.destroy();
4169+
// When the negotiated application defines a "request rejected" code
4170+
// (HTTP/3: H3_REQUEST_REJECTED), reset the stream with it so the peer
4171+
// learns the request was not processed (RFC 9114 section 4.1.1).
4172+
// Other applications have no such semantic and are torn down as before.
4173+
constrejectedCode=getQuicSessionState(this).requestRejectedCode;
4174+
if(getQuicSessionState(this).streamCallbacksSupported===1){
4175+
stream.destroy(undefined,{code: rejectedCode});
4176+
}else{
4177+
stream.destroy();
4178+
}
41704179
return;
41714180
}
41724181

β€Žlib/internal/quic/state.jsβ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ const {
7777
IDX_STATE_SESSION_APPLICATION_TYPE,
7878
IDX_STATE_SESSION_NO_ERROR_CODE,
7979
IDX_STATE_SESSION_INTERNAL_ERROR_CODE,
80+
IDX_STATE_SESSION_REQUEST_REJECTED_CODE,
8081
IDX_STATE_SESSION_MAX_DATAGRAM_SIZE,
8182
IDX_STATE_SESSION_LAST_DATAGRAM_ID,
8283
IDX_STATE_SESSION_MAX_PENDING_DATAGRAMS,
@@ -125,6 +126,7 @@ assert(IDX_STATE_SESSION_WRAPPED !== undefined);
125126
assert(IDX_STATE_SESSION_APPLICATION_TYPE!==undefined);
126127
assert(IDX_STATE_SESSION_NO_ERROR_CODE!==undefined);
127128
assert(IDX_STATE_SESSION_INTERNAL_ERROR_CODE!==undefined);
129+
assert(IDX_STATE_SESSION_REQUEST_REJECTED_CODE!==undefined);
128130
assert(IDX_STATE_SESSION_MAX_DATAGRAM_SIZE!==undefined);
129131
assert(IDX_STATE_SESSION_LAST_DATAGRAM_ID!==undefined);
130132
assert(IDX_STATE_ENDPOINT_BOUND!==undefined);
@@ -552,6 +554,13 @@ class QuicSessionState {
552554
handle,this.#offset +IDX_STATE_SESSION_INTERNAL_ERROR_CODE,kIsLittleEndian);
553555
}
554556

557+
getrequestRejectedCode(){
558+
consthandle=this.#handle;
559+
if(handle===undefined)returnundefined;
560+
returnDataViewPrototypeGetBigUint64(
561+
handle,this.#offset +IDX_STATE_SESSION_REQUEST_REJECTED_CODE,kIsLittleEndian);
562+
}
563+
555564
/** @type {number} */
556565
getmaxDatagramSize(){
557566
consthandle=this.#handle;

β€Žsrc/quic/application.ccβ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,11 @@ class DefaultApplication final : public Session::Application {
280280
returnNGTCP2_INTERNAL_ERROR;
281281
}
282282

283+
// Raw QUIC has no "request rejected" semantic; reuse the no-error code.
284+
error_code GetRequestRejectedCode() constoverride {
285+
returnGetNoErrorCode();
286+
}
287+
283288
voidEarlyDataRejected() override {
284289
// Destroy all open streams β€” ngtcp2 has already discarded their
285290
// internal state when it rejected the early data. Use the

β€Žsrc/quic/application.hβ€Ž

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,14 @@ class Session::Application : public MemoryRetainer {
7777
// NGTCP2_INTERNAL_ERROR (0x1).
7878
virtual error_code GetInternalErrorCode() const = 0;
7979

80+
// The "request rejected" code is sent on RESET_STREAM when an incoming
81+
// request stream is rejected without any application processing (e.g.
82+
// the session has no consumer for it), so the peer learns the request
83+
// was not processed. For HTTP/3 this is NGHTTP3_H3_REQUEST_REJECTED
84+
// (0x10b); other applications have no such semantic and reuse the
85+
// "no error" code.
86+
virtual error_code GetRequestRejectedCode() const = 0;
87+
8088
// Called after Session::Receive processes a packet, outside all callback
8189
// scopes. Applications can use this to handle deferred operations that
8290
// require calling into JS (e.g., HTTP/3 GOAWAY processing).

β€Žsrc/quic/http3.ccβ€Ž

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,10 @@ class Http3ApplicationImpl final : public Session::Application {
172172
returnNGHTTP3_H3_INTERNAL_ERROR;
173173
}
174174

175+
error_code GetRequestRejectedCode() constoverride {
176+
returnNGHTTP3_H3_REQUEST_REJECTED;
177+
}
178+
175179
voidEarlyDataRejected() override {
176180
// When 0-RTT is rejected, destroy the nghttp3 connection and all
177181
// open streams β€” ngtcp2 has discarded their internal state.

β€Žsrc/quic/session.ccβ€Ž

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ uint64_t MaxDatagramPayload(uint64_t max_frame_size) {
141141
V(APPLICATION_TYPE, application_type, uint8_t) \
142142
V(NO_ERROR_CODE, no_error_code, error_code) \
143143
V(INTERNAL_ERROR_CODE, internal_error_code, error_code) \
144+
V(REQUEST_REJECTED_CODE, request_rejected_code, error_code) \
144145
V(MAX_DATAGRAM_SIZE, max_datagram_size, uint16_t) \
145146
V(LAST_DATAGRAM_ID, last_datagram_id, datagram_id) \
146147
V(MAX_PENDING_DATAGRAMS, max_pending_datagrams, uint16_t)
@@ -2660,6 +2661,7 @@ void Session::SetApplication(std::unique_ptr<Application> app) {
26602661
// without duplicating the per-application table.
26612662
impl_->state()->no_error_code = app->GetNoErrorCode();
26622663
impl_->state()->internal_error_code = app->GetInternalErrorCode();
2664+
impl_->state()->request_rejected_code = app->GetRequestRejectedCode();
26632665
impl_->application_ = std::move(app);
26642666
}
26652667

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
// Flags: --experimental-quic --no-warnings
2+
3+
// An incoming HTTP/3 request stream that is rejected without any
4+
// application processing (here, the session has no stream consumer) is
5+
// reset with H3_REQUEST_REJECTED (0x10b) so the peer learns the request
6+
// was not processed. See RFC 9114 section 4.1.1.
7+
// Refs: https://github.com/nodejs/node/issues/65441
8+
9+
import{hasQuic,skip,mustCall}from'../common/index.mjs';
10+
importassertfrom'node:assert';
11+
import*asfixturesfrom'../common/fixtures.mjs';
12+
13+
if(!hasQuic){
14+
skip('QUIC is not enabled');
15+
}
16+
17+
const{ listen, connect }=awaitimport('node:quic');
18+
const{ createPrivateKey }=awaitimport('node:crypto');
19+
20+
constkey=createPrivateKey(fixtures.readKey('agent1-key.pem'));
21+
constcert=fixtures.readKey('agent1-cert.pem');
22+
23+
// RFC 9114 H3_REQUEST_REJECTED.
24+
constH3_REQUEST_REJECTED=0x10bn;
25+
26+
// The server registers no stream consumer, so an incoming request stream
27+
// is rejected on arrival.
28+
constserverEndpoint=awaitlisten(mustCall((serverSession)=>{
29+
serverSession.onerror=()=>{};
30+
}),{
31+
sni: {'*': {keys: [key],certs: [cert]}},
32+
});
33+
34+
constclientSession=awaitconnect(serverEndpoint.address,{
35+
servername: 'localhost',
36+
verifyPeer: 'manual',
37+
});
38+
awaitclientSession.opened;
39+
40+
constreset=Promise.withResolvers();
41+
conststream=awaitclientSession.createBidirectionalStream({
42+
headers: {
43+
':method': 'GET',
44+
':path': '/test',
45+
':scheme': 'https',
46+
':authority': 'localhost',
47+
},
48+
});
49+
stream.onreset=mustCall((err)=>{
50+
assert.strictEqual(err.code,'ERR_QUIC_APPLICATION_ERROR');
51+
assert.strictEqual(err.errorCode,H3_REQUEST_REJECTED);
52+
reset.resolve();
53+
});
54+
awaitassert.rejects(stream.closed,{code: 'ERR_QUIC_APPLICATION_ERROR'});
55+
56+
awaitreset.promise;
57+
awaitclientSession.close();
58+
awaitserverEndpoint.close();

0 commit comments

Comments
Β (0)