module: reduce the number of URL initializations

PR-URL: #48272
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: anonrig

lib/internal/main/check_syntax.js

@@ -3,6 +3,7 @@
 // If user passed `-c` or `--check` arguments to Node, check its syntax
 // instead of actually running the file.
 
+const{URL}=require('internal/url');
 const{
  prepareMainThreadExecution,
  markBootstrapComplete,
@@ -55,7 +56,7 @@ async function checkSyntax(source, filename) {
 const{ defaultResolve }=require('internal/modules/esm/resolve');
 const{ defaultGetFormat }=require('internal/modules/esm/get_format');
 const{ url }=awaitdefaultResolve(pathToFileURL(filename).toString());
-constformat=awaitdefaultGetFormat(url);
+constformat=awaitdefaultGetFormat(newURL(url));
 isModule=format==='module';
 }
 if(isModule){

lib/internal/modules/esm/get_format.js

@@ -20,7 +20,7 @@ const experimentalNetworkImports =
 constexperimentalSpecifierResolution=
 getOptionValue('--experimental-specifier-resolution');
 const{ getPackageType, getPackageScopeConfig }=require('internal/modules/esm/resolve');
-const{URL,fileURLToPath }=require('internal/url');
+const{ fileURLToPath }=require('internal/url');
 const{ERR_UNKNOWN_FILE_EXTENSION}=require('internal/errors').codes;
 
 constprotocolHandlers={
@@ -99,27 +99,29 @@ function getHttpProtocolModuleFormat(url, context) {
 }
 
 /**
- * @param {URL | URL['href']} url
+ * @param {URL} url
  * @param {{parentURL: string}} context
  * @returns {Promise<string> | string | undefined} only works when enabled
  */
 functiondefaultGetFormatWithoutErrors(url,context){
-constparsed=newURL(url);
-if(!ObjectPrototypeHasOwnProperty(protocolHandlers,parsed.protocol))
+constprotocol=url.protocol;
+if(!ObjectPrototypeHasOwnProperty(protocolHandlers,protocol)){
 returnnull;
-returnprotocolHandlers[parsed.protocol](parsed,context,true);
+}
+returnprotocolHandlers[protocol](url,context,true);
 }
 
 /**
- * @param {URL | URL['href']} url
+ * @param {URL} url
  * @param {{parentURL: string}} context
  * @returns {Promise<string> | string | undefined} only works when enabled
  */
 functiondefaultGetFormat(url,context){
-constparsed=newURL(url);
-returnObjectPrototypeHasOwnProperty(protocolHandlers,parsed.protocol) ?
-protocolHandlers[parsed.protocol](parsed,context,false) :
-null;
+constprotocol=url.protocol;
+if(!ObjectPrototypeHasOwnProperty(protocolHandlers,protocol)){
+returnnull;
+}
+returnprotocolHandlers[protocol](url,context,false);
 }
 
 module.exports={

lib/internal/modules/esm/load.js

@@ -77,11 +77,11 @@ async function defaultLoad(url, context) {
  source,
 }=context;
 
-throwIfUnsupportedURLScheme(newURL(url),experimentalNetworkImports);
+consturlInstance=newURL(url);
 
-if(format==null){
-format=awaitdefaultGetFormat(url,context);
-}
+throwIfUnsupportedURLScheme(urlInstance,experimentalNetworkImports);
+
+format??=awaitdefaultGetFormat(urlInstance,context);
 
 validateAssertions(url,format,importAssertions);