crypto: remove rsaPrivate and rename rsaPublic

This commit renames rsaPublic and removes the rsaPrivate function as the
code in these two functions are identical.
Backport-PR-URL: #20706
PR-URL: #20164
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: danbev

lib/internal/crypto/cipher.js

@@ -33,7 +33,7 @@ const { StringDecoder } = require('string_decoder');
 const{ inherits }=require('util');
 const{ deprecate, normalizeEncoding }=require('internal/util');
 
-functionrsaPublic(method,defaultPadding){
+functionrsaFunctionFor(method,defaultPadding){
 returnfunction(options,buffer){
 constkey=options.key||options;
 constpadding=options.padding||defaultPadding;
@@ -42,19 +42,10 @@ function rsaPublic(method, defaultPadding) {
 };
 }
 
-functionrsaPrivate(method,defaultPadding){
-returnfunction(options,buffer){
-constkey=options.key||options;
-constpassphrase=options.passphrase||null;
-constpadding=options.padding||defaultPadding;
-returnmethod(toBuf(key),buffer,padding,passphrase);
-};
-}
-
-constpublicEncrypt=rsaPublic(_publicEncrypt,RSA_PKCS1_OAEP_PADDING);
-constpublicDecrypt=rsaPublic(_publicDecrypt,RSA_PKCS1_PADDING);
-constprivateEncrypt=rsaPrivate(_privateEncrypt,RSA_PKCS1_PADDING);
-constprivateDecrypt=rsaPrivate(_privateDecrypt,RSA_PKCS1_OAEP_PADDING);
+constpublicEncrypt=rsaFunctionFor(_publicEncrypt,RSA_PKCS1_OAEP_PADDING);
+constpublicDecrypt=rsaFunctionFor(_publicDecrypt,RSA_PKCS1_PADDING);
+constprivateEncrypt=rsaFunctionFor(_privateEncrypt,RSA_PKCS1_PADDING);
+constprivateDecrypt=rsaFunctionFor(_privateDecrypt,RSA_PKCS1_OAEP_PADDING);
 
 functiongetDecoder(decoder,encoding){
 encoding=normalizeEncoding(encoding);