inspector: fix session.disconnect crash

PR-URL: #46942
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: theanarkh

src/inspector_js_api.cc

@@ -122,9 +122,11 @@ class JSBindingsConnection : public AsyncWrap {
 newJSBindingsConnection(env, info.This(), callback);
  }
 
+// See https://github.com/nodejs/node/pull/46942
 voidDisconnect() {
+ BaseObjectPtr<JSBindingsConnection> strong_ref{this};
  session_.reset();
-deletethis;
+Detach();
  }
 
 staticvoidDisconnect(const FunctionCallbackInfo<Value>& info) {

test/parallel/test-inspector-connect-to-main-thread.js

@@ -0,0 +1,20 @@
+'use strict';
+constcommon=require('../common');
+
+common.skipIfInspectorDisabled();
+
+const{ Session }=require('inspector');
+const{ Worker, isMainThread, workerData }=require('worker_threads');
+
+if(!workerData){
+common.skipIfWorker();
+}
+
+if(isMainThread){
+newWorker(__filename,{workerData: {}});
+}else{
+constsession=newSession();
+session.connectToMainThread();
+// Do not crash
+session.disconnect();
+}