zlib: use for...of

trivikr · targos · commit 61da6571fe75 · 2020-01-14T16:56:21.000+01:00
PR-URL: #31051 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -92,9 +92,7 @@ const codes = {
 Z_VERSION_ERROR: constants.Z_VERSION_ERROR
 };
 
-const ckeys = ObjectKeys(codes);
-for (let ck = 0; ck < ckeys.length; ck++) {
- const ckey = ckeys[ck];
+for (const ckey of ObjectKeys(codes)) {
 codes[codes[ckey]] = ckey;
 }
 
@@ -912,9 +910,7 @@ ObjectDefineProperties(module.exports, {
 
 // These should be considered deprecated
 // expose all the zlib constants
-const bkeys = ObjectKeys(constants);
-for (let bk = 0; bk < bkeys.length; bk++) {
- const bkey = bkeys[bk];
+for (const bkey of ObjectKeys(constants)) {
 if (bkey.startsWith('BROTLI')) continue;
 ObjectDefineProperty(module.exports, bkey, {
 enumerable: false, value: constants[bkey], writable: false

-Original file line number
+Diff line change
 Z_VERSION_ERROR: constants.Z_VERSION_ERROR
 };
 -constckeys=ObjectKeys(codes);
 -for(letck=0;ck<ckeys.length;ck++){
 -constckey=ckeys[ck];
 +for(constckeyofObjectKeys(codes)){
 codes[codes[ckey]]=ckey;
+}
 // These should be considered deprecated
 // expose all the zlib constants
 -constbkeys=ObjectKeys(constants);
 -for(letbk=0;bk<bkeys.length;bk++){
 -constbkey=bkeys[bk];
 +for(constbkeyofObjectKeys(constants)){
 if(bkey.startsWith('BROTLI'))continue;
 ObjectDefineProperty(module.exports,bkey,{
 enumerable: false,value: constants[bkey],writable: false