timers: check for nullish instead of falsy in loops

Trott · danielleadams · commit 63a67f8dad40 · 2022-03-14T09:32:03.000-04:00
This prepares the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/internal/timers.js b/lib/internal/timers.js
@@ -490,7 +490,7 @@ function getTimerCallbacks(runNextTicks) {
 
 let list;
 let ranAtLeastOneList = false;
- while (list = timerListQueue.peek()) {
+ while ((list = timerListQueue.peek()) != null) {
 if (list.expiry > now) {
 nextExpiry = list.expiry;
 return refCount > 0 ? nextExpiry : -nextExpiry;
@@ -511,7 +511,7 @@ function getTimerCallbacks(runNextTicks) {
 
 let ranAtLeastOneTimer = false;
 let timer;
- while (timer = L.peek(list)) {
+ while ((timer = L.peek(list)) != null) {
 const diff = now - timer._idleStart;
 
 // Check if this loop iteration is too early for the next timer.

-Original file line number
+Diff line change
 letlist;
 letranAtLeastOneList=false;
 -while(list=timerListQueue.peek()){
 +while((list=timerListQueue.peek())!=null){
 if(list.expiry>now){
 nextExpiry=list.expiry;
 returnrefCount>0 ? nextExpiry : -nextExpiry;
 letranAtLeastOneTimer=false;
 lettimer;
 -while(timer=L.peek(list)){
 +while((timer=L.peek(list))!=null){
 constdiff=now-timer._idleStart;
 // Check if this loop iteration is too early for the next timer.