lib: replace MessageEvent with undici's

undici's MessageEvent is better tested and has a complete WebIDL
implementation for validation. Not only this, but it's also used in
Node's current WebSocket implementation. There are a large number of
webidl-related issues in the current MessageEvent, such as not
implementing `MessageEvent.prototype.initMessageEvent`, not validating
arguments passed to its constructor
(#51771), not validating the values
passed to the constructor (such as not validating that `ports` is a
sequence, not converting origin to a USVString, etc.), and other issues.
fixup
PR-URL: #52370
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

Author: KhafraDev

lib/.eslintrc.yaml

@@ -67,7 +67,7 @@ rules:
  - name: MessageChannel
 message: Use `const { MessageChannel } = require('internal/worker/io');` instead of the global.
  - name: MessageEvent
-message: Use `const { MessageEvent } = require('internal/worker/io');` instead of the global.
+message: Use `const { MessageEvent } = require('internal/deps/undici/undici');` instead of the global.
  - name: MessagePort
 message: Use `const { MessagePort } = require('internal/worker/io');` instead of the global.
  - name: Navigator

lib/internal/bootstrap/web/exposed-window-or-worker.js

@@ -39,7 +39,7 @@ defineLazyProperties(globalThis, 'buffer', ['atob', 'btoa']);
 // https://html.spec.whatwg.org/multipage/web-messaging.html#broadcasting-to-other-browsing-contexts
 exposeLazyInterfaces(globalThis,'internal/worker/io',['BroadcastChannel']);
 exposeLazyInterfaces(globalThis,'internal/worker/io',[
-'MessageChannel','MessagePort','MessageEvent',
+'MessageChannel','MessagePort',
 ]);
 // https://www.w3.org/TR/FileAPI/#dfn-Blob
 exposeLazyInterfaces(globalThis,'internal/blob',['Blob']);
@@ -78,7 +78,7 @@ ObjectDefineProperty(globalThis, 'fetch', {
 // https://fetch.spec.whatwg.org/#request-class
 // https://fetch.spec.whatwg.org/#response-class
 exposeLazyInterfaces(globalThis,'internal/deps/undici/undici',[
-'FormData','Headers','Request','Response',
+'FormData','Headers','Request','Response','MessageEvent',
 ]);
 
 // https://websockets.spec.whatwg.org/

lib/internal/worker/io.js

@@ -20,7 +20,6 @@ const {
 }=primordials;
 
 const{
- kEmptyObject,
  kEnumerableProperty,
  setOwnProperty,
 }=require('internal/util');
@@ -38,7 +37,6 @@ const {
  moveMessagePortToContext,
 receiveMessageOnPort: receiveMessageOnPort_,
  stopMessagePort,
- checkMessagePort,
  DOMException,
 }=internalBinding('messaging');
 const{
@@ -59,25 +57,19 @@ const {
 const{ inspect }=require('internal/util/inspect');
 const{
 codes: {
-ERR_INVALID_ARG_TYPE,
 ERR_INVALID_THIS,
 ERR_MISSING_ARGS,
 },
 }=require('internal/errors');
 
-constkData=Symbol('kData');
 constkHandle=Symbol('kHandle');
 constkIncrementsPortRef=Symbol('kIncrementsPortRef');
-constkLastEventId=Symbol('kLastEventId');
 constkName=Symbol('kName');
-constkOrigin=Symbol('kOrigin');
 constkOnMessage=Symbol('kOnMessage');
 constkOnMessageError=Symbol('kOnMessageError');
 constkPort=Symbol('kPort');
-constkPorts=Symbol('kPorts');
 constkWaitingStreams=Symbol('kWaitingStreams');
 constkWritableCallbacks=Symbol('kWritableCallbacks');
-constkSource=Symbol('kSource');
 constkStartedReading=Symbol('kStartedReading');
 constkStdioWantsMoreDataCallback=Symbol('kStdioWantsMoreDataCallback');
 constkCurrentlyReceivingPorts=
@@ -93,6 +85,11 @@ const messageTypes = {
 LOAD_SCRIPT: 'loadScript',
 };
 
+letmessageEvent;
+functionlazyMessageEvent(){
+returnmessageEvent??=require('internal/deps/undici/undici').MessageEvent;
+}
+
 // We have to mess with the MessagePort prototype a bit, so that a) we can make
 // it inherit from NodeEventTarget, even though it is a C++ class, and b) we do
 // not provide methods that are not present in the Browser and not documented
@@ -119,95 +116,6 @@ MessagePort.prototype.hasRef = function() {
 return!!FunctionPrototypeCall(MessagePortPrototype.hasRef,this);
 };
 
-functionvalidateMessagePort(port,name){
-if(!checkMessagePort(port))
-thrownewERR_INVALID_ARG_TYPE(name,'MessagePort',port);
-}
-
-functionisMessageEvent(value){
-returnvalue!=null&&kDatainvalue;
-}
-
-classMessageEventextendsEvent{
-constructor(type,{
- data =null,
- origin ='',
- lastEventId ='',
- source =null,
- ports =[],
-}=kEmptyObject){
-super(type);
-this[kData]=data;
-this[kOrigin]=`${origin}`;
-this[kLastEventId]=`${lastEventId}`;
-this[kSource]=source;
-this[kPorts]=[...ports];
-
-if(this[kSource]!==null)
-validateMessagePort(this[kSource],'init.source');
-for(leti=0;i<this[kPorts].length;i++)
-validateMessagePort(this[kPorts][i],`init.ports[${i}]`);
-}
-}
-
-ObjectDefineProperties(MessageEvent.prototype,{
-data: {
-__proto__: null,
-get(){
-if(!isMessageEvent(this))
-thrownewERR_INVALID_THIS('MessageEvent');
-returnthis[kData];
-},
-enumerable: true,
-configurable: true,
-set: undefined,
-},
-origin: {
-__proto__: null,
-get(){
-if(!isMessageEvent(this))
-thrownewERR_INVALID_THIS('MessageEvent');
-returnthis[kOrigin];
-},
-enumerable: true,
-configurable: true,
-set: undefined,
-},
-lastEventId: {
-__proto__: null,
-get(){
-if(!isMessageEvent(this))
-thrownewERR_INVALID_THIS('MessageEvent');
-returnthis[kLastEventId];
-},
-enumerable: true,
-configurable: true,
-set: undefined,
-},
-source: {
-__proto__: null,
-get(){
-if(!isMessageEvent(this))
-thrownewERR_INVALID_THIS('MessageEvent');
-returnthis[kSource];
-},
-enumerable: true,
-configurable: true,
-set: undefined,
-},
-ports: {
-__proto__: null,
-get(){
-if(!isMessageEvent(this))
-thrownewERR_INVALID_THIS('MessageEvent');
-returnthis[kPorts];
-},
-enumerable: true,
-configurable: true,
-set: undefined,
-},
-});
-
 constoriginalCreateEvent=EventTarget.prototype[kCreateEvent];
 ObjectDefineProperty(
 MessagePort.prototype,
@@ -220,7 +128,7 @@ ObjectDefineProperty(
 }
 constports=this[kCurrentlyReceivingPorts];
 this[kCurrentlyReceivingPorts]=undefined;
-returnnewMessageEvent(type,{ data, ports });
+returnnew(lazyMessageEvent())(type,{ data, ports });
 },
 configurable: false,
 writable: false,
@@ -413,7 +321,7 @@ function receiveMessageOnPort(port) {
 }
 
 functiononMessageEvent(type,data){
-this.dispatchEvent(newMessageEvent(type,{ data }));
+this.dispatchEvent(new(lazyMessageEvent())(type,{ data }));
 }
 
 functionisBroadcastChannel(value){
@@ -546,7 +454,6 @@ module.exports = {
  moveMessagePortToContext,
  MessagePort,
  MessageChannel,
- MessageEvent,
  receiveMessageOnPort,
  setupPortReferencing,
  ReadableWorkerStdio,

test/parallel/test-messageevent-brandcheck.js

@@ -1,21 +1,14 @@
-// Flags: --expose-internals
 'use strict';
 
 require('../common');
 constassert=require('assert');
 
-const{
- MessageEvent,
-}=require('internal/worker/io');
-
 [
 'data',
 'origin',
 'lastEventId',
 'source',
 'ports',
 ].forEach((i)=>{
-assert.throws(()=>Reflect.get(MessageEvent.prototype,i,{}),{
-code: 'ERR_INVALID_THIS',
-});
+assert.throws(()=>Reflect.get(MessageEvent.prototype,i,{}),TypeError);
 });

test/parallel/test-worker-message-event.js

@@ -61,31 +61,31 @@ const dummyPort = new MessageChannel().port1;
 assert.throws(()=>{
 newMessageEvent('message',{source: 1});
 },{
-code: 'ERR_INVALID_ARG_TYPE',
-message: /The"init\.source"propertymustbeaninstanceofMessagePort/,
+name: 'TypeError',
+message: /Expected1tobeaninstanceofMessagePort/,
 });
 assert.throws(()=>{
 newMessageEvent('message',{source: {}});
 },{
-code: 'ERR_INVALID_ARG_TYPE',
-message: /The"init\.source"propertymustbeaninstanceofMessagePort/,
+name: 'TypeError',
+message: /Expected{}tobeaninstanceofMessagePort/,
 });
 assert.throws(()=>{
 newMessageEvent('message',{ports: 0});
 },{
-message: /portsisnotiterable/,
+message: /Sequence:ValueoftypeNumberisnotanObject/,
 });
 assert.throws(()=>{
 newMessageEvent('message',{ports: [null]});
 },{
-code: 'ERR_INVALID_ARG_TYPE',
-message: /The"init\.ports\[0\]"propertymustbeaninstanceofMessagePort/,
+name: 'TypeError',
+message: /ExpectednulltobeaninstanceofMessagePort/,
 });
 assert.throws(()=>{
 newMessageEvent('message',{ports: [{}]});
 },{
-code: 'ERR_INVALID_ARG_TYPE',
-message: /The"init\.ports\[0\]"propertymustbeaninstanceofMessagePort/,
+name: 'TypeError',
+message: /Expected{}tobeaninstanceofMessagePort/,
 });
 }