test: guarantee test runs in test-readline-keys

Trott · MylesBorins · commit 646f82520ca6 · 2017-03-08T17:11:21.000-08:00
Use common.mustCall() to guarantee that test functions (created by a factory function) are run. PR-URL: #11023 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-readline-keys.js b/test/parallel/test-readline-keys.js
@@ -1,10 +1,10 @@
 'use strict';
-require('../common');
-var PassThrough = require('stream').PassThrough;
-var assert = require('assert');
-var inherits = require('util').inherits;
-var extend = require('util')._extend;
-var Interface = require('readline').Interface;
+const common = require('../common');
+const PassThrough = require('stream').PassThrough;
+const assert = require('assert');
+const inherits = require('util').inherits;
+const extend = require('util')._extend;
+const Interface = require('readline').Interface;
 
 
 function FakeInput() {
@@ -55,7 +55,7 @@ function addTest(sequences, expectedKeys) {
 
 const addKeyIntervalTest = (sequences, expectedKeys, interval = 550,
 assertDelay = 550) => {
- return (next) => () => {
+ const fn = common.mustCall((next) => () => {
 
 if (!Array.isArray(sequences)) {
 sequences = [ sequences ];
@@ -84,7 +84,8 @@ const addKeyIntervalTest = (sequences, expectedKeys, interval = 550,
 }
 };
 emitKeys(sequences);
- };
+ });
+ return fn;
 };
 
 // regular alphanumerics

-Original file line number
+Diff line change
@@ @@ -1,10 +1,10 @@ @@
 'use strict';
 -require('../common');
 -varPassThrough=require('stream').PassThrough;
 -varassert=require('assert');
 -varinherits=require('util').inherits;
 -varextend=require('util')._extend;
 -varInterface=require('readline').Interface;
 +constcommon=require('../common');
 +constPassThrough=require('stream').PassThrough;
 +constassert=require('assert');
 +constinherits=require('util').inherits;
 +constextend=require('util')._extend;
 +constInterface=require('readline').Interface;
 functionFakeInput(){
 constaddKeyIntervalTest=(sequences,expectedKeys,interval=550,
 assertDelay=550)=>{
 -return(next)=>()=>{
 +constfn=common.mustCall((next)=>()=>{
 if(!Array.isArray(sequences)){
 sequences=[sequences];
+}
 };
 emitKeys(sequences);
 -};
 +});
 +returnfn;
 };
 // regular alphanumerics