test: improve n-api array func coverage

- add coverage for napi_has_element
- add coverage for napi_create_array_with_length
PR-URL: #12890
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: mhdawson

test/addons-napi/test_array/test.js

@@ -19,19 +19,31 @@ const array = [
 ]
 ];
 
-assert.strictEqual(test_array.Test(array,array.length+1),
-'Index out of bound!');
+assert.throws(
+()=>{
+test_array.TestGetElement(array,array.length+1);
+},
+/^Error:assertion\(\(\(uint32_t\)index<length\)\)failed:Indexoutofbounds!$/
+);
 
 assert.throws(
 ()=>{
-test_array.Test(array,-2);
+test_array.TestGetElement(array,-2);
 },
-/Invalidindex\.Expectsapositiveinteger\./
+/^Error:assertion\(index>=0\)failed:Invalidindex\.Expectsapositiveinteger\.$/
 );
 
 array.forEach(function(element,index){
-assert.strictEqual(test_array.Test(array,index),element);
+assert.strictEqual(test_array.TestGetElement(array,index),element);
 });
 
 
 assert.deepStrictEqual(test_array.New(array),array);
+
+assert(test_array.TestHasElement(array,0));
+assert.strictEqual(test_array.TestHasElement(array,array.length+1),false);
+
+assert(test_array.NewWithLength(0)instanceofArray);
+assert(test_array.NewWithLength(1)instanceofArray);
+// check max allowed length for an array 2^32 -1
+assert(test_array.NewWithLength(4294967295)instanceofArray);

test/addons-napi/test_array/test_array.c

@@ -2,7 +2,7 @@
 #include<string.h>
 #include"../common.h"
 
-napi_valueTest(napi_envenv, napi_callback_infoinfo) {
+napi_valueTestGetElement(napi_envenv, napi_callback_infoinfo) {
 size_targc=2;
 napi_valueargs[2];
 NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
@@ -37,17 +37,49 @@ napi_value Test(napi_env env, napi_callback_info info) {
 uint32_tlength;
 NAPI_CALL(env, napi_get_array_length(env, array, &length));
 
-if ((uint32_t)index >= length) {
-napi_valuestr;
-constchar*str_val="Index out of bound!";
-size_tstr_len=strlen(str_val);
-NAPI_CALL(env, napi_create_string_utf8(env, str_val, str_len, &str));
+NAPI_ASSERT(env, ((uint32_t)index<length), "Index out of bounds!");
 
-returnstr;
+napi_valueret;
+NAPI_CALL(env, napi_get_element(env, array, index, &ret));
+
+returnret;
+}
+
+napi_valueTestHasElement(napi_envenv, napi_callback_infoinfo) {
+size_targc=2;
+napi_valueargs[2];
+NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
+
+NAPI_ASSERT(env, argc >= 2, "Wrong number of arguments");
+
+napi_valuetypevaluetype0;
+NAPI_CALL(env, napi_typeof(env, args[0], &valuetype0));
+
+NAPI_ASSERT(env, valuetype0==napi_object,
+"Wrong type of arguments. Expects an array as first argument.");
+
+napi_valuetypevaluetype1;
+NAPI_CALL(env, napi_typeof(env, args[1], &valuetype1));
+
+NAPI_ASSERT(env, valuetype1==napi_number,
+"Wrong type of arguments. Expects an integer as second argument.");
+
+napi_valuearray=args[0];
+int32_tindex;
+NAPI_CALL(env, napi_get_value_int32(env, args[1], &index));
+
+boolisarray;
+NAPI_CALL(env, napi_is_array(env, array, &isarray));
+
+if (!isarray) {
+returnNULL;
  }
 
+boolhas_element;
+NAPI_CALL(env, napi_has_element(env, array, index, &has_element));
+
 napi_valueret;
-NAPI_CALL(env, napi_get_element(env, array, index, &ret));
+NAPI_CALL(env, napi_get_boolean(env, has_element, &ret));
 
 returnret;
 }
@@ -80,10 +112,34 @@ napi_value New(napi_env env, napi_callback_info info) {
 returnret;
 }
 
+napi_valueNewWithLength(napi_envenv, napi_callback_infoinfo) {
+size_targc=1;
+napi_valueargs[1];
+NAPI_CALL(env, napi_get_cb_info(env, info, &argc, args, NULL, NULL));
+
+NAPI_ASSERT(env, argc >= 1, "Wrong number of arguments");
+
+napi_valuetypevaluetype0;
+NAPI_CALL(env, napi_typeof(env, args[0], &valuetype0));
+
+NAPI_ASSERT(env, valuetype0==napi_number,
+"Wrong type of arguments. Expects an integer the first argument.");
+
+int32_tarray_length;
+NAPI_CALL(env, napi_get_value_int32(env, args[0], &array_length));
+
+napi_valueret;
+NAPI_CALL(env, napi_create_array_with_length(env, array_length, &ret));
+
+returnret;
+}
+
 voidInit(napi_envenv, napi_valueexports, napi_valuemodule, void*priv) {
 napi_property_descriptordescriptors[] = {
-DECLARE_NAPI_PROPERTY("Test", Test),
+DECLARE_NAPI_PROPERTY("TestGetElement", TestGetElement),
+DECLARE_NAPI_PROPERTY("TestHasElement", TestHasElement),
 DECLARE_NAPI_PROPERTY("New", New),
+DECLARE_NAPI_PROPERTY("NewWithLength", NewWithLength),
  };
 
 NAPI_CALL_RETURN_VOID(env, napi_define_properties(