test: allow EAI_FAIL in test-http-dns-error.js

cjihrig · targos · commit 66cf70652143 · 2019-05-04T09:20:21.000+02:00
EAI_FAIL is expected on OpenBSD, and has been observed on platforms such as FreeBSD and Windows. This commit makes EAI_FAIL an acceptable error code on all platforms. PR-URL: #27500 Fixes: #27487 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/parallel/test-http-dns-error.js b/test/parallel/test-http-dns-error.js
@@ -32,9 +32,7 @@ const https = require('https');
 const host = '*'.repeat(64);
 const MAX_TRIES = 5;
 
-let errCode = 'ENOTFOUND';
-if (common.isOpenBSD)
- errCode = 'EAI_FAIL';
+const errCodes = ['ENOTFOUND', 'EAI_FAIL'];
 
 function tryGet(mod, tries) {
 // Bad host name should not throw an uncatchable exception.
@@ -45,7 +43,7 @@ function tryGet(mod, tries) {
 tryGet(mod, ++tries);
 return;
 }
- assert.strictEqual(err.code, errCode);
+ assert(errCodes.includes(err.code), err);
 }));
 // http.get() called req1.end() for us
 }
@@ -61,7 +59,7 @@ function tryRequest(mod, tries) {
 tryRequest(mod, ++tries);
 return;
 }
- assert.strictEqual(err.code, errCode);
+ assert(errCodes.includes(err.code), err);
 }));
 req.end();
 }

-Original file line number
+Diff line change
 consthost='*'.repeat(64);
 constMAX_TRIES=5;
 -leterrCode='ENOTFOUND';
 -if(common.isOpenBSD)
 -errCode='EAI_FAIL';
 +consterrCodes=['ENOTFOUND','EAI_FAIL'];
 functiontryGet(mod,tries){
 // Bad host name should not throw an uncatchable exception.
 tryGet(mod,++tries);
 return;
+}
 -assert.strictEqual(err.code,errCode);
 +assert(errCodes.includes(err.code),err);
 }));
 // http.get() called req1.end() for us
+}
 tryRequest(mod,++tries);
 return;
+}
 -assert.strictEqual(err.code,errCode);
 +assert(errCodes.includes(err.code),err);
 }));
 req.end();
+}