lib: move initialization of APIs for changing process state

Whether these APIs should be available for Node.js instances
semantically depends on whether the current Node.js instance
was assigned ownership of process-wide state, and not whether
it refers to the main thread or not.
PR-URL: #31172
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

Author: addaleax

lib/internal/bootstrap/switches/does_not_own_process_state.js

@@ -1,11 +1,16 @@
 'use strict';
 
 constcredentials=internalBinding('credentials');
+constrawMethods=internalBinding('process_methods');
+// TODO: this should be detached from ERR_WORKER_UNSUPPORTED_OPERATION
+const{ unavailable }=require('internal/process/worker_thread_only');
 
-if(credentials.implementsPosixCredentials){
-// TODO: this should be detached from ERR_WORKER_UNSUPPORTED_OPERATION
-const{ unavailable }=require('internal/process/worker_thread_only');
+process.abort=unavailable('process.abort()');
+process.chdir=unavailable('process.chdir()');
+process.umask=wrappedUmask;
+process.cwd=rawMethods.cwd;
 
+if(credentials.implementsPosixCredentials){
 process.initgroups=unavailable('process.initgroups()');
 process.setgroups=unavailable('process.setgroups()');
 process.setegid=unavailable('process.setegid()');
@@ -16,3 +21,16 @@ if (credentials.implementsPosixCredentials) {
 
 // ---- keep the attachment of the wrappers above so that it's easier to ----
 // ---- compare the setups side-by-side -----
+
+const{
+codes: {ERR_WORKER_UNSUPPORTED_OPERATION}
+}=require('internal/errors');
+
+functionwrappedUmask(mask){
+// process.umask() is a read-only operation in workers.
+if(mask!==undefined){
+thrownewERR_WORKER_UNSUPPORTED_OPERATION('Setting process.umask()');
+}
+
+returnrawMethods.umask(mask);
+}

lib/internal/bootstrap/switches/does_own_process_state.js

@@ -1,6 +1,12 @@
 'use strict';
 
 constcredentials=internalBinding('credentials');
+constrawMethods=internalBinding('process_methods');
+
+process.abort=rawMethods.abort;
+process.umask=wrappedUmask;
+process.chdir=wrappedChdir;
+process.cwd=wrappedCwd;
 
 if(credentials.implementsPosixCredentials){
 constwrapped=wrapPosixCredentialSetters(credentials);
@@ -16,6 +22,11 @@ if (credentials.implementsPosixCredentials) {
 // ---- keep the attachment of the wrappers above so that it's easier to ----
 // ---- compare the setups side-by-side -----
 
+const{
+ parseMode,
+ validateString
+}=require('internal/validators');
+
 functionwrapPosixCredentialSetters(credentials){
 const{
  ArrayIsArray,
@@ -94,3 +105,26 @@ function wrapPosixCredentialSetters(credentials) {
 setuid: wrapIdSetter('User',_setuid)
 };
 }
+
+// Cache the working directory to prevent lots of lookups. If the working
+// directory is changed by `chdir`, it'll be updated.
+letcachedCwd='';
+
+functionwrappedChdir(directory){
+validateString(directory,'directory');
+rawMethods.chdir(directory);
+// Mark cache that it requires an update.
+cachedCwd='';
+}
+
+functionwrappedUmask(mask){
+if(mask!==undefined){
+mask=parseMode(mask,'mask');
+}
+returnrawMethods.umask(mask);
+}
+
+functionwrappedCwd(){
+cachedCwd=rawMethods.cwd();
+returncachedCwd;
+}

lib/internal/bootstrap/switches/is_main_thread.js

@@ -3,11 +3,6 @@
 const{ ObjectDefineProperty }=primordials;
 constrawMethods=internalBinding('process_methods');
 
-process.abort=rawMethods.abort;
-process.umask=wrappedUmask;
-process.chdir=wrappedChdir;
-process.cwd=wrappedCwd;
-
 // TODO(joyeecheung): deprecate and remove these underscore methods
 process._debugProcess=rawMethods._debugProcess;
 process._debugEnd=rawMethods._debugEnd;
@@ -38,33 +33,6 @@ process.on('removeListener', stopListeningIfSignal);
 // ---- compare the setups side-by-side -----
 
 const{ guessHandleType }=internalBinding('util');
-const{
- parseMode,
- validateString
-}=require('internal/validators');
-
-// Cache the working directory to prevent lots of lookups. If the working
-// directory is changed by `chdir`, it'll be updated.
-letcachedCwd='';
-
-functionwrappedChdir(directory){
-validateString(directory,'directory');
-rawMethods.chdir(directory);
-// Mark cache that it requires an update.
-cachedCwd='';
-}
-
-functionwrappedUmask(mask){
-if(mask!==undefined){
-mask=parseMode(mask,'mask');
-}
-returnrawMethods.umask(mask);
-}
-
-functionwrappedCwd(){
-cachedCwd=rawMethods.cwd();
-returncachedCwd;
-}
 
 functioncreateWritableStdioStream(fd){
 letstream;

lib/internal/bootstrap/switches/is_not_main_thread.js

@@ -1,15 +1,6 @@
 'use strict';
 
 const{ ObjectDefineProperty }=primordials;
-constrawMethods=internalBinding('process_methods');
-const{
- unavailable
-}=require('internal/process/worker_thread_only');
-
-process.abort=unavailable('process.abort()');
-process.chdir=unavailable('process.chdir()');
-process.umask=wrappedUmask;
-process.cwd=rawMethods.cwd;
 
 deleteprocess._debugProcess;
 deleteprocess._debugEnd;
@@ -42,9 +33,6 @@ process.removeListener('removeListener', stopListeningIfSignal);
 const{
  createWorkerStdio
 }=require('internal/worker/io');
-const{
-codes: {ERR_WORKER_UNSUPPORTED_OPERATION}
-}=require('internal/errors');
 
 letworkerStdio;
 functionlazyWorkerStdio(){
@@ -57,12 +45,3 @@ function getStdout() { return lazyWorkerStdio().stdout; }
 functiongetStderr(){returnlazyWorkerStdio().stderr;}
 
 functiongetStdin(){returnlazyWorkerStdio().stdin;}
-
-functionwrappedUmask(mask){
-// process.umask() is a read-only operation in workers.
-if(mask!==undefined){
-thrownewERR_WORKER_UNSUPPORTED_OPERATION('Setting process.umask()');
-}
-
-returnrawMethods.umask(mask);
-}