http2: throw better error when accessing unbound socket proxy

Fixes: #22268
Backport-PR-URL: #22850
PR-URL: #22486
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Author: jasnell

doc/api/errors.md

@@ -843,6 +843,12 @@ The `Http2Session` settings canceled.
 An attempt was made to connect a `Http2Session` object to a `net.Socket` or
 `tls.TLSSocket` that had already been bound to another `Http2Session` object.
 
+<aid="ERR_HTTP2_SOCKET_UNBOUND"></a>
+### ERR_HTTP2_SOCKET_UNBOUND
+
+An attempt was made to use the `socket` property of an `Http2Session` that
+has already been closed.
+
 <aid="ERR_HTTP2_STATUS_101"></a>
 ### ERR_HTTP2_STATUS_101
 

lib/internal/errors.js

@@ -338,6 +338,8 @@ E('ERR_HTTP2_SESSION_ERROR', 'Session closed with error code %s');
 E('ERR_HTTP2_SETTINGS_CANCEL','HTTP2 session settings canceled');
 E('ERR_HTTP2_SOCKET_BOUND',
 'The socket is already bound to an Http2Session');
+E('ERR_HTTP2_SOCKET_UNBOUND',
+'The socket has been disconnected from the Http2Session');
 E('ERR_HTTP2_STATUS_101',
 'HTTP status code 101 (Switching Protocols) is forbidden in HTTP/2');
 E('ERR_HTTP2_STATUS_INVALID','Invalid status code: %s');

lib/internal/http2/core.js

@@ -641,12 +641,17 @@ const proxySocketHandler = {
 thrownewerrors.Error('ERR_HTTP2_NO_SOCKET_MANIPULATION');
 default:
 constsocket=session[kSocket];
+if(socket===undefined)
+thrownewerrors.Error('ERR_HTTP2_SOCKET_UNBOUND');
 constvalue=socket[prop];
 returntypeofvalue==='function' ? value.bind(socket) : value;
 }
 },
 getPrototypeOf(session){
-returnReflect.getPrototypeOf(session[kSocket]);
+constsocket=session[kSocket];
+if(socket===undefined)
+thrownewerrors.Error('ERR_HTTP2_SOCKET_UNBOUND');
+returnReflect.getPrototypeOf(socket);
 },
 set(session,prop,value){
 switch(prop){
@@ -662,7 +667,10 @@ const proxySocketHandler = {
 case'write':
 thrownewerrors.Error('ERR_HTTP2_NO_SOCKET_MANIPULATION');
 default:
-session[kSocket][prop]=value;
+constsocket=session[kSocket];
+if(socket===undefined)
+thrownewerrors.Error('ERR_HTTP2_SOCKET_UNBOUND');
+socket[prop]=value;
 returntrue;
 }
 }

test/parallel/test-http2-unbound-socket-proxy.js

@@ -0,0 +1,69 @@
+'use strict';
+
+constcommon=require('../common');
+if(!common.hasCrypto)
+common.skip('missing crypto');
+consthttp2=require('http2');
+constnet=require('net');
+
+constserver=http2.createServer();
+server.on('stream',common.mustCall((stream)=>{
+stream.respond();
+stream.end('ok');
+}));
+
+server.listen(0,common.mustCall(()=>{
+constclient=http2.connect(`http://localhost:${server.address().port}`);
+constsocket=client.socket;
+constreq=client.request();
+req.resume();
+req.on('close',common.mustCall(()=>{
+client.close();
+server.close();
+
+// Tests to make sure accessing the socket proxy fails with an
+// informative error.
+setImmediate(common.mustCall(()=>{
+common.expectsError(()=>{
+socket.example;
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socket.example=1;
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socketinstanceofnet.Socket;
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socket.ref();
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socket.unref();
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socket.setEncoding();
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socket.setKeepAlive();
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+common.expectsError(()=>{
+socket.setNoDelay();
+},{
+code: 'ERR_HTTP2_SOCKET_UNBOUND'
+});
+}));
+}));
+}));