os: improve path check with direct index access

mertcanaltin · aduh95 · commit 6ab59c81b6a7 · 2024-11-05T15:14:03.000+01:00
PR-URL: #55434 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
diff --git a/lib/os.js b/lib/os.js
@@ -26,7 +26,6 @@ const {
 Float64Array,
 NumberParseInt,
 ObjectDefineProperties,
- StringPrototypeEndsWith,
 StringPrototypeSlice,
 SymbolToPrimitive,
 } = primordials;
@@ -184,9 +183,9 @@ function tmpdir() {
 process.env.TMP ||
 (process.env.SystemRoot || process.env.windir) + '\\temp';
 
- if (path.length > 1 && StringPrototypeEndsWith(path, '\\') &&
- !StringPrototypeEndsWith(path, ':\\'))
+ if (path.length > 1 && path[path.length - 1] === '\\' && path[path.length - 2] !== ':') {
 return StringPrototypeSlice(path, 0, -1);
+ }
 
 return path;
 }

-Original file line number
+Diff line change
  Float64Array,
  NumberParseInt,
  ObjectDefineProperties,
 - StringPrototypeEndsWith,
  StringPrototypeSlice,
  SymbolToPrimitive,
 }=primordials;
 process.env.TMP||
 (process.env.SystemRoot||process.env.windir)+'\\temp';
 -if(path.length>1&&StringPrototypeEndsWith(path,'\\')&&
 -!StringPrototypeEndsWith(path,':\\'))
 +if(path.length>1&&path[path.length-1]==='\\'&&path[path.length-2]!==':'){
 returnStringPrototypeSlice(path,0,-1);
 +}
 returnpath;
+}