fs: detect dot files when using globstar

Using globstar in glob pattern should not prevent dot (hidden) files
from being matched.
PR-URL: #61012Fixes: #56321
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Author: robinvw1

lib/internal/fs/glob.js

@@ -442,7 +442,18 @@ class Glob {
 constfromSymlink=pattern.symlinks.has(index);
 
 if(current===lazyMinimatch().GLOBSTAR){
-if(entry.name[0]==='.'||(this.#exclude &&this.#exclude(this.#withFileTypes ? entry : entry.name))){
+constisDot=entry.name[0]==='.';
+constnextMatches=pattern.test(nextIndex,entry.name);
+
+letnextNonGlobIndex=nextIndex;
+while(pattern.at(nextNonGlobIndex)===lazyMinimatch().GLOBSTAR){
+nextNonGlobIndex++;
+}
+
+constmatchesDot=isDot&&pattern.test(nextNonGlobIndex,entry.name);
+
+if((isDot&&!matchesDot)||
+(this.#exclude &&this.#exclude(this.#withFileTypes ? entry : entry.name))){
 continue;
 }
 if(!fromSymlink&&entry.isDirectory()){
@@ -455,7 +466,6 @@ class Glob {
 
 // Any pattern after ** is also a potential pattern
 // so we can already test it here
-constnextMatches=pattern.test(nextIndex,entry.name);
 if(nextMatches&&nextIndex===last&&!isLast){
 // If next pattern is the last one, add to results
 this.#results.add(entryPath);
@@ -642,30 +652,36 @@ class Glob {
 constfromSymlink=pattern.symlinks.has(index);
 
 if(current===lazyMinimatch().GLOBSTAR){
-if(entry.name[0]==='.'||(this.#exclude &&this.#exclude(this.#withFileTypes ? entry : entry.name))){
+constisDot=entry.name[0]==='.';
+constnextMatches=pattern.test(nextIndex,entry.name);
+
+letnextNonGlobIndex=nextIndex;
+while(pattern.at(nextNonGlobIndex)===lazyMinimatch().GLOBSTAR){
+nextNonGlobIndex++;
+}
+
+constmatchesDot=isDot&&pattern.test(nextNonGlobIndex,entry.name);
+
+if((isDot&&!matchesDot)||
+(this.#exclude &&this.#exclude(this.#withFileTypes ? entry : entry.name))){
 continue;
 }
 if(!fromSymlink&&entry.isDirectory()){
 // If directory, add ** to its potential patterns
 subPatterns.add(index);
 }elseif(!fromSymlink&&index===last){
 // If ** is last, add to results
-if(!this.#results.has(entryPath)){
-if(this.#results.add(entryPath)){
-yieldthis.#withFileTypes ? entry : entryPath;
-}
+if(!this.#results.has(entryPath)&&this.#results.add(entryPath)){
+yieldthis.#withFileTypes ? entry : entryPath;
 }
 }
 
 // Any pattern after ** is also a potential pattern
 // so we can already test it here
-constnextMatches=pattern.test(nextIndex,entry.name);
 if(nextMatches&&nextIndex===last&&!isLast){
 // If next pattern is the last one, add to results
-if(!this.#results.has(entryPath)){
-if(this.#results.add(entryPath)){
-yieldthis.#withFileTypes ? entry : entryPath;
-}
+if(!this.#results.has(entryPath)&&this.#results.add(entryPath)){
+yieldthis.#withFileTypes ? entry : entryPath;
 }
 }elseif(nextMatches&&entry.isDirectory()){
 // Pattern matched, meaning two patterns forward

test/parallel/test-fs-glob.mjs

@@ -30,6 +30,8 @@ async function setup() {
 'a/cb/e/f',
 'a/x/.y/b',
 'a/z/.y/b',
+'a/.b',
+'a/b/.b',
 ].map((f)=>resolve(fixtureDir,f));
 
 constsymlinkTo=resolve(fixtureDir,'a/symlink/a/b/c');
@@ -188,6 +190,9 @@ const patterns = {
 ],
 '*/*/*/f': ['a/bc/e/f','a/cb/e/f'],
 './**/f': ['a/bc/e/f','a/cb/e/f'],
+'**/.b': ['a/.b','a/b/.b'],
+'./**/.b': ['a/.b','a/b/.b'],
+'a/**/.b': ['a/.b','a/b/.b'],
 'a/symlink/a/b/c/a/b/c/a/b/c//a/b/c////a/b/c/**/b/c/**': common.isWindows ? [] : [
 'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c',
 'a/symlink/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a/b/c/a',