lib: move duplicate spliceOne into internal/util

lib/url.js and lib/events.js are using the same spliceOne function.
This change is to move it into the internal/util for avoiding duplicate
code.
PR-URL: #16221
Backport-PR-URL: #16433
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

Author: starkwang

lib/events.js

@@ -22,6 +22,7 @@
 'use strict';
 
 vardomain;
+varspliceOne;
 
 functionEventEmitter(){
 EventEmitter.init.call(this);
@@ -389,8 +390,11 @@ EventEmitter.prototype.removeListener =
 
 if(position===0)
 list.shift();
-else
+else{
+if(spliceOne===undefined)
+spliceOne=require('internal/util').spliceOne;
 spliceOne(list,position);
+}
 
 if(list.length===1)
 events[type]=list[0];
@@ -502,13 +506,6 @@ EventEmitter.prototype.eventNames = function eventNames() {
 returnthis._eventsCount>0 ? Reflect.ownKeys(this._events) : [];
 };
 
-// About 1.5x faster than the two-arg version of Array#splice().
-functionspliceOne(list,index){
-for(vari=index,k=i+1,n=list.length;k<n;i+=1,k+=1)
-list[i]=list[k];
-list.pop();
-}
-
 functionarrayClone(arr,n){
 varcopy=newArray(n);
 for(vari=0;i<n;++i)

lib/internal/util.js

@@ -266,6 +266,13 @@ function join(output, separator) {
 returnstr;
 }
 
+// About 1.5x faster than the two-arg version of Array#splice().
+functionspliceOne(list,index){
+for(vari=index,k=i+1,n=list.length;k<n;i+=1,k+=1)
+list[i]=list[k];
+list.pop();
+}
+
 module.exports={
  assertCrypto,
  cachedResult,
@@ -276,10 +283,11 @@ module.exports = {
  filterDuplicateStrings,
  getConstructorOf,
  isError,
+ join,
  normalizeEncoding,
  objectToString,
  promisify,
-join,
+spliceOne,
 
 // Symbol used to customize promisify conversion
 customPromisifyArgs: kCustomPromisifyArgsSymbol,

lib/url.js

@@ -25,6 +25,7 @@ const { toASCII } = process.binding('config').hasIntl ?
 process.binding('icu') : require('punycode');
 
 const{ hexTable }=require('internal/querystring');
+const{ spliceOne }=require('internal/util');
 
 // WHATWG URL implementation provided by internal/url
 const{
@@ -948,13 +949,6 @@ Url.prototype.parseHost = function parseHost() {
 if(host)this.hostname=host;
 };
 
-// About 1.5x faster than the two-arg version of Array#splice().
-functionspliceOne(list,index){
-for(vari=index,k=i+1,n=list.length;k<n;i+=1,k+=1)
-list[i]=list[k];
-list.pop();
-}
-
 // These characters do not need escaping:
 // ! - . _ ~
 // ' ( ) * :