test: change common.PORT to arbitrary port

Trott · targos · commit 6cedeb1aa840 · 2020-01-13T16:35:50.000+01:00
Change common.PORT to arbitrary port in test-child-process-fork-getconnections to prepare for moving that test from sequential to parallel. PR-URL: #30749 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/test/sequential/test-child-process-fork-getconnections.js b/test/sequential/test-child-process-fork-getconnections.js
@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-const common = require('../common');
+require('../common');
 const assert = require('assert');
 const fork = require('child_process').fork;
 const net = require('net');
@@ -79,7 +79,7 @@ if (process.argv[2] === 'child') {
 server.on('listening', function() {
 let j = count;
 while (j--) {
- const client = net.connect(common.PORT, '127.0.0.1');
+ const client = net.connect(server.address().port, '127.0.0.1');
 client.on('close', function() {
 disconnected += 1;
 });
@@ -110,7 +110,7 @@ if (process.argv[2] === 'child') {
 closeEmitted = true;
 });
 
- server.listen(common.PORT, '127.0.0.1');
+ server.listen(0, '127.0.0.1');
 
 process.on('exit', function() {
 assert.strictEqual(sent, count);

-Original file line number
+Diff line change
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 'use strict';
 -constcommon=require('../common');
 +require('../common');
 constassert=require('assert');
 constfork=require('child_process').fork;
 constnet=require('net');
 server.on('listening',function(){
 letj=count;
 while(j--){
 -constclient=net.connect(common.PORT,'127.0.0.1');
 +constclient=net.connect(server.address().port,'127.0.0.1');
 client.on('close',function(){
 disconnected+=1;
 });
 closeEmitted=true;
 });
 -server.listen(common.PORT,'127.0.0.1');
 +server.listen(0,'127.0.0.1');
 process.on('exit',function(){
 assert.strictEqual(sent,count);