test: os, replace custom flatten method with built-in Array.flat

waelsy123 · danielleadams · commit 6d86f8afd502 · 2021-05-31T15:34:54.000-04:00
PR-URL: #38770 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-os.js b/test/parallel/test-os.js
@@ -39,10 +39,6 @@ const is = {
 }
 };
 
-const flatten = (arr) =>
- arr.reduce((acc, c) =>
- acc.concat(Array.isArray(c) ? flatten(c) : c), []);
-
 process.env.TMPDIR = '/tmpdir';
 process.env.TMP = '/tmp';
 process.env.TEMP = '/temp';
@@ -174,7 +170,8 @@ const netmaskToCIDRSuffixMap = new Map(Object.entries({
 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff': 128
 }));
 
-flatten(Object.values(interfaces))
+Object.values(interfaces)
+ .flat(Infinity)
 .map((v) => ({ v, mask: netmaskToCIDRSuffixMap.get(v.netmask) }))
 .forEach(({ v, mask }) => {
 assert.ok('cidr' in v, `"cidr" prop not found in ${inspect(v)}`);

-Original file line number
+Diff line change
+}
 };
 -constflatten=(arr)=>
 -arr.reduce((acc,c)=>
 -acc.concat(Array.isArray(c) ? flatten(c) : c),[]);
+-
 process.env.TMPDIR='/tmpdir';
 process.env.TMP='/tmp';
 process.env.TEMP='/temp';
 'ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff': 128
 }));
 -flatten(Object.values(interfaces))
 +Object.values(interfaces)
 +.flat(Infinity)
 .map((v)=>({ v,mask: netmaskToCIDRSuffixMap.get(v.netmask)}))
 .forEach(({ v, mask })=>{
 assert.ok('cidr'inv,`"cidr" prop not found in ${inspect(v)}`);