events: define event handler as enumerable

benjamingr · targos · commit 6e21e8283f80 · 2021-04-30T12:00:10.000+02:00
PR-URL: #35931 Backport-PR-URL: #38386 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -591,7 +591,9 @@ function defineEventHandler(emitter, name) {
 emitter.addEventListener(name, value);
 }
 eventHandlerValue = value;
- }
+ },
+ configurable: true,
+ enumerable: true
 });
 }
 module.exports = {
diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -517,3 +517,10 @@ let asyncTest = Promise.resolve();
 }));
 target.dispatchEvent(new Event('foo'));
 }
+{
+ const target = new EventTarget();
+ defineEventHandler(target, 'foo');
+ const descriptor = Object.getOwnPropertyDescriptor(target, 'onfoo');
+ strictEqual(descriptor.configurable, true);
+ strictEqual(descriptor.enumerable, true);
+}

Original file line number	Diff line number	Diff line change
`@@ -591,7 +591,9 @@ function defineEventHandler(emitter, name) {`
`591`	`591`	`emitter.addEventListener(name,value);`
`592`	`592`	`}`
`593`	`593`	`eventHandlerValue=value;`
`594`		`-}`
	`594`	`+},`
	`595`	`+configurable: true,`
	`596`	`+enumerable: true`
`595`	`597`	`});`
`596`	`598`	`}`
`597`	`599`	`module.exports={`
-Original file line number
+Diff line change
 }));
 target.dispatchEvent(newEvent('foo'));
+}
 +{
 +consttarget=newEventTarget();
 +defineEventHandler(target,'foo');
 +constdescriptor=Object.getOwnPropertyDescriptor(target,'onfoo');
 +strictEqual(descriptor.configurable,true);
 +strictEqual(descriptor.enumerable,true);
 +}