lib: no need to strip BOM or shebang for scripts

PR-URL: #27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: refack

lib/internal/main/check_syntax.js

@@ -13,10 +13,6 @@ const {
 
 const{ pathToFileURL }=require('url');
 
-const{
- stripShebangOrBOM,
-}=require('internal/modules/cjs/helpers');
-
 const{
 Module: {
 _resolveFilename: resolveCJSModuleName,
@@ -68,5 +64,5 @@ function checkSyntax(source, filename) {
 }
 }
 
-wrapSafe(filename,stripShebangOrBOM(source));
+wrapSafe(filename,source);
 }

lib/internal/modules/cjs/helpers.js

@@ -52,37 +52,6 @@ function stripBOM(content) {
 returncontent;
 }
 
-/**
- * Find end of shebang line and slice it off
- */
-functionstripShebang(content){
-// Remove shebang
-if(content.charAt(0)==='#'&&content.charAt(1)==='!'){
-// Find end of shebang line and slice it off
-letindex=content.indexOf('\n',2);
-if(index===-1)
-return'';
-if(content.charAt(index-1)==='\r')
-index--;
-// Note that this actually includes the newline character(s) in the
-// new output. This duplicates the behavior of the regular expression
-// that was previously used to replace the shebang line.
-content=content.slice(index);
-}
-returncontent;
-}
-
-// Strip either the shebang or UTF BOM of a file.
-// Note that this only processes one. If both occur in
-// either order, the one that comes second is not
-// significant.
-functionstripShebangOrBOM(content){
-if(content.charCodeAt(0)===0xFEFF){
-returncontent.slice(1);
-}
-returnstripShebang(content);
-}
-
 constbuiltinLibs=[
 'assert','async_hooks','buffer','child_process','cluster','crypto',
 'dgram','dns','domain','events','fs','http','http2','https','net',
@@ -148,6 +117,4 @@ module.exports = {
  makeRequireFunction,
  normalizeReferrerURL,
  stripBOM,
- stripShebang,
- stripShebangOrBOM,
 };

lib/internal/modules/cjs/loader.js

@@ -40,7 +40,6 @@ const {
  makeRequireFunction,
  normalizeReferrerURL,
  stripBOM,
- stripShebangOrBOM,
 }=require('internal/modules/cjs/helpers');
 const{ getOptionValue }=require('internal/options');
 constpreserveSymlinks=getOptionValue('--preserve-symlinks');
@@ -745,9 +744,6 @@ Module.prototype._compile = function(content, filename) {
 manifest.assertIntegrity(moduleURL,content);
 }
 
-// Strip after manifest integrity check
-content=stripShebangOrBOM(content);
-
 constcompiledWrapper=wrapSafe(filename,content);
 
 varinspectorWrapper=null;

test/fixtures/utf8-bom-shebang.js test/fixtures/utf8-bom-shebang-shebang.jstest/fixtures/utf8-bom-shebang.js renamed to test/fixtures/utf8-bom-shebang-shebang.js

@@ -1,2 +1,3 @@
 #!shebang
+#!shebang
 module.exports=42;

test/parallel/test-internal-modules-strip-shebang.js

@@ -355,7 +355,7 @@ assert.strictEqual(require('../fixtures/utf8-bom.json'), 42);
 // Loading files with BOM + shebang.
 // See https://github.com/nodejs/node/issues/27767
 assert.throws(()=>{
-require('../fixtures/utf8-bom-shebang.js');
+require('../fixtures/utf8-bom-shebang-shebang.js');
 },{name: 'SyntaxError'});
 assert.strictEqual(require('../fixtures/utf8-shebang-bom.js'),42);