url: declare iterator inside loop

trivikr · targos · commit 70dc7a2672b2 · 2020-01-14T08:30:29.000+01:00
Refs: #30281 (comment) PR-URL: #30509 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/url.js b/lib/url.js
@@ -162,8 +162,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
 let end = -1;
 let rest = '';
 let lastPos = 0;
- let i = 0;
- for (let inWs = false, split = false; i < url.length; ++i) {
+ for (let i = 0, inWs = false, split = false; i < url.length; ++i) {
 const code = url.charCodeAt(i);
 
 // Find first and last non-whitespace characters for trimming
@@ -295,7 +294,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
 let hostEnd = -1;
 let atSign = -1;
 let nonHost = -1;
- for (i = 0; i < rest.length; ++i) {
+ for (let i = 0; i < rest.length; ++i) {
 switch (rest.charCodeAt(i)) {
 case CHAR_TAB:
 case CHAR_LINE_FEED:
@@ -411,7 +410,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) {
 
 let questionIdx = -1;
 let hashIdx = -1;
- for (i = 0; i < rest.length; ++i) {
+ for (let i = 0; i < rest.length; ++i) {
 const code = rest.charCodeAt(i);
 if (code === CHAR_HASH) {
 this.hash = rest.slice(i);

-Original file line number
+Diff line change
 letend=-1;
 letrest='';
 letlastPos=0;
 -leti=0;
 -for(letinWs=false,split=false;i<url.length;++i){
 +for(leti=0,inWs=false,split=false;i<url.length;++i){
 constcode=url.charCodeAt(i);
 // Find first and last non-whitespace characters for trimming
 lethostEnd=-1;
 letatSign=-1;
 letnonHost=-1;
 -for(i=0;i<rest.length;++i){
 +for(leti=0;i<rest.length;++i){
 switch(rest.charCodeAt(i)){
 caseCHAR_TAB:
 caseCHAR_LINE_FEED:
 letquestionIdx=-1;
 lethashIdx=-1;
 -for(i=0;i<rest.length;++i){
 +for(leti=0;i<rest.length;++i){
 constcode=rest.charCodeAt(i);
 if(code===CHAR_HASH){
 this.hash=rest.slice(i);